#1662 - HAL FORMS template target must be a URL.

We now expand the affordance link before we add it to the HAL FORMS template.

Also see #1660.

Author: odrotbohm

src/main/java/org/springframework/hateoas/mediatype/hal/forms/HalFormsTemplateBuilder.java

@@ -70,7 +70,7 @@ public Map<String, HalFormsTemplate> findTemplates(RepresentationModel<?> resour
 							.withProperties(factory.createProperties(it))
 							.withContentType(it.getInput().getPrimaryMediaType());
 
-					String target = it.getLink().getHref();
+					String target = it.getLink().expand().getHref();
 
 					if (selfLink == null || !target.equals(selfLink.getHref())) {
 						template = template.withTarget(target);

src/test/java/org/springframework/hateoas/mediatype/hal/forms/HalFormsTemplateBuilderUnitTest.java

@@ -230,6 +230,22 @@ void exposesHttpMethodInAllCaps() {
 		assertThat(HalFormsTemplate.forMethod(HttpMethod.POST).getMethod()).isEqualTo("POST");
 	}
 
+	@Test
+	void expandsAffordanceLinkForFormTarget() {
+
+		HalFormsConfiguration configuration = new HalFormsConfiguration();
+
+		RepresentationModel<?> models = new RepresentationModel<>(
+				Affordances.of(Link.of("/example{?foo}", LinkRelation.of("example"))) //
+						.afford(HttpMethod.POST) //
+						.toLink());
+
+		Map<String, HalFormsTemplate> templates = new HalFormsTemplateBuilder(configuration, MessageResolver.DEFAULTS_ONLY)
+				.findTemplates(models);
+
+		assertThat(templates.get("default").getTarget()).endsWith("/example");
+	}
+
 	@Getter
 	static class PatternExample extends RepresentationModel<PatternExample> {