Polish Tests

Issue gh-11992

Author: jzheaux

core/src/main/java/org/springframework/security/core/context/ObservationSecurityContextChangedListener.java

@@ -33,11 +33,11 @@
  */
 public final class ObservationSecurityContextChangedListener implements SecurityContextChangedListener {
 
-	private static final String SECURITY_CONTEXT_CREATED = "security.context.created";
+	static final String SECURITY_CONTEXT_CREATED = "security.context.created";
 
-	private static final String SECURITY_CONTEXT_CHANGED = "security.context.changed";
+	static final String SECURITY_CONTEXT_CHANGED = "security.context.changed";
 
-	private static final String SECURITY_CONTEXT_CLEARED = "security.context.cleared";
+	static final String SECURITY_CONTEXT_CLEARED = "security.context.cleared";
 
 	private final ObservationRegistry registry;
 
@@ -60,7 +60,7 @@ public void securityContextChanged(SecurityContextChangedEvent event) {
 			return;
 		}
 		if (event.isCleared()) {
-			observation.event(Observation.Event.of("security.context.cleared"));
+			observation.event(Observation.Event.of(SECURITY_CONTEXT_CLEARED));
 			return;
 		}
 		Authentication oldAuthentication = getAuthentication(event.getOldContext());

core/src/test/java/org/springframework/security/core/context/ObservationSecurityContextChangedListenerTests.java

@@ -66,7 +66,8 @@ void securityContextChangedWhenClearedEventThenAddsClearEventToObservation() {
 				.securityContextChanged(new SecurityContextChangedEvent(one, SecurityContextChangedEvent.NO_CONTEXT));
 		ArgumentCaptor<Observation.Event> event = ArgumentCaptor.forClass(Observation.Event.class);
 		verify(observation).event(event.capture());
-		assertThat(event.getValue().getName()).isEqualTo("security.context.cleared");
+		assertThat(event.getValue().getName())
+				.isEqualTo(ObservationSecurityContextChangedListener.SECURITY_CONTEXT_CLEARED);
 		verifyNoInteractions(one);
 	}
 
@@ -85,7 +86,8 @@ void securityContextChangedWhenChangedEventThenAddsChangeEventToObservation() {
 		this.tested.securityContextChanged(new SecurityContextChangedEvent(this.one, this.two));
 		ArgumentCaptor<Observation.Event> event = ArgumentCaptor.forClass(Observation.Event.class);
 		verify(observation).event(event.capture());
-		assertThat(event.getValue().getName()).isEqualTo("security.context.changed");
+		assertThat(event.getValue().getName())
+				.isEqualTo(ObservationSecurityContextChangedListener.SECURITY_CONTEXT_CHANGED);
 	}
 
 	@Test
@@ -95,7 +97,8 @@ void securityContextChangedWhenCreatedEventThenAddsCreatedEventToObservation() {
 		this.tested.securityContextChanged(new SecurityContextChangedEvent(null, this.one));
 		ArgumentCaptor<Observation.Event> event = ArgumentCaptor.forClass(Observation.Event.class);
 		verify(observation).event(event.capture());
-		assertThat(event.getValue().getName()).isEqualTo("security.context.created");
+		assertThat(event.getValue().getName())
+				.isEqualTo(ObservationSecurityContextChangedListener.SECURITY_CONTEXT_CREATED);
 	}
 
 }