Skip to content

Provide a way to swallow RequestRejectedException stacktrace #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Glamdring opened this issue Mar 21, 2018 · 2 comments
Closed

Provide a way to swallow RequestRejectedException stacktrace #5149

Glamdring opened this issue Mar 21, 2018 · 2 comments
Assignees
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@Glamdring
Copy link

Summary

If the HttpFirewall rejects a request, it does that by throwing an exception (as all other outcomes would not stop the execution of the filter chain). However, this exception bubbles up and eventually gets printed in the logs/console, and that's not desirable, as it's not an actual exception.

Expected Behavior

Instead of propagating the exception, the FilterChainProxy should catch it, log a one-line warning, and respond with BAD_REQUEST.

Version

5.0.3.RELEASE

@rwinch
Copy link
Member

rwinch commented Mar 21, 2018

Thanks for the report! This is a duplicate of #5007

@rwinch rwinch closed this as completed Mar 21, 2018
@rwinch rwinch self-assigned this Mar 21, 2018
@rwinch rwinch added status: duplicate A duplicate of another issue type: enhancement A general enhancement labels Mar 21, 2018
@rwinch
Copy link
Member

rwinch commented Mar 21, 2018

PS: See the mentioned issue for ways to handle it until support is added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants