Skip to content

Timers in persisted machines #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvalkeal opened this issue Feb 10, 2017 · 5 comments
Open

Timers in persisted machines #311

jvalkeal opened this issue Feb 10, 2017 · 5 comments
Labels
type/enhancement Is an enhancement request

Comments

@jvalkeal
Copy link
Contributor

This obviously is a very tricky. Lets say that there is a timer which fires and may take machine to some other state. Nothing will happen if machine is not running(as it is hibernated into storage). Should think some ways to do this.

@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label Feb 10, 2017
@davidtepel
Copy link

We have similar issue - or it is the same one?
We have noticed that the timers are not removed if the machine is removed, i.e creating a new machine instance.
This causes us memroy leaks in the application:
image

@jvalkeal
Copy link
Contributor Author

yeah, that's a different issue but I created #321 for it. Tried it and definitely a bug.

@davidtepel
Copy link

Thanks for the update

@jvalkeal
Copy link
Contributor Author

jvalkeal commented Mar 9, 2017

@davidtepel you could actually check if fix(1.2.3 snapshots) for #321 helped with this issue as I made some fixes to stop triggering when machine is stopped.

@davidtepel
Copy link

Actually we had to find another solution for the timers becuse of this bug and also, a requirement in which the timeout of the timer should be dynamic. i.e, change the periodic timer timout on the fly without creating a new state machine (in order to change retry mechanism in the same state machine).
So I can't check...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants