Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

[Plugins] Should the plugin package be moved out of internal? #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linux2647 opened this issue Jun 18, 2022 · 0 comments
Closed

[Plugins] Should the plugin package be moved out of internal? #1688

linux2647 opened this issue Jun 18, 2022 · 0 comments
Labels
bug Something isn't working triage New issues that hasn't been reviewed

Comments

@linux2647
Copy link
Contributor

Version

1.14.0

What happened?

I wanted to play around with authoring a plugin, but after reading the documentation and looking at the example code, I realized that the plugin package, which contains the protobuf-emitted code, lives under internal. By definition this means that no Go code outside of sqlc can import it. I saw that the ultimate goal is to have WASM-based plugins, but #1578 indicates that development on that has been stalled, opting for process-based plugins for the time being.

Am I missing something obvious that makes it possible to write a process-based plugin? Or does the plugin package need to be moved out of internal?

Relevant log output

No response

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

No response

What database engines are you using?

No response

What type of code are you generating?

No response

@linux2647 linux2647 added bug Something isn't working triage New issues that hasn't been reviewed labels Jun 18, 2022
@sqlc-dev sqlc-dev locked and limited conversation to collaborators Jun 25, 2022
@kyleconroy kyleconroy converted this issue into discussion #1703 Jun 25, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working triage New issues that hasn't been reviewed
Projects
None yet
Development

No branches or pull requests

1 participant