Skip to content

Commit 5d86a08

Browse files
authored
Merge pull request #218 from erizocosmico/perf/delete
improve memory footprint and performance of deletes
2 parents 5543a44 + c3baf72 commit 5d86a08

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

store.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,14 @@ func (s *Store) Delete(schema Schema, record Record) error {
293293
return ErrEmptyID
294294
}
295295

296-
_, err := s.builder.
297-
Delete(schema.Table()).
298-
Where(squirrel.Eq{
299-
schema.ID().String(): record.GetID(),
300-
}).
301-
Exec()
296+
var query bytes.Buffer
297+
query.WriteString("DELETE FROM ")
298+
query.WriteString(schema.Table())
299+
query.WriteString(" WHERE ")
300+
query.WriteString(schema.ID().String())
301+
query.WriteString("=$1")
302+
303+
_, err := s.proxy.Exec(query.String(), record.GetID())
302304
return err
303305
}
304306

0 commit comments

Comments
 (0)