Skip to content

Commit 48fcab8

Browse files
committed
fix: error expected false, but got true on <button disabled></button> -> dont render prop at all if it is a boolean and is false (this commit matches purescript-halogen/purescript-halogen-vdom@cfd471e)
1 parent 5f245c7 commit 48fcab8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/Halogen/VDom/DOM/StringRenderer.purs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ renderProperty ∷ String → PropValue → Maybe String
4343
renderProperty name prop = case typeOf (unsafeToForeign prop) of
4444
"string" → renderAttr name' $ (unsafeCoerce PropValue String) prop
4545
"number" → renderAttr name' $ show ((unsafeCoerce PropValue String) prop)
46-
"boolean"Just $ escape name'
46+
"boolean"
47+
if ((unsafeCoerce :: PropValue -> Boolean) prop)
48+
then Just $ escape name'
49+
else Nothing
4750
_ → Nothing
4851
where
4952
name' = propNameToAttrName name

0 commit comments

Comments
 (0)