refactor: process Snyk warnings

Author: sswietoniowski

javascript/01_basics/05_strings.js

@@ -18,6 +18,7 @@ console.log(firstName.charAt(2));
 console.log(firstName.substring(0, 3));
 console.log(firstName.slice(0, 3));
 console.log(val.split(' '));
+// deepcode ignore GlobalReplacementRegex: this is just a demo code
 console.log(val.replace(' ', '|'));
 console.log(val.includes('John')); // tests whether a string contains another string
 

javascript/01_basics/06_arrays.js

@@ -25,6 +25,7 @@ console.log(numbers.pop());
 console.log(numbers.shift());
 console.log(numbers);
 console.log(numbers.splice(1, 3));
+// deepcode ignore PureMethodReturnValueIgnored: this is just a demo code
 numbers.slice(2, 4);
 console.log(numbers);
 val = numbers.concat([1, 2, 3]);

javascript/01_basics/09_conditionals.js

@@ -1,9 +1,11 @@
 // If statement
 let id = 100;
 id = '100';
+// file deepcode ignore IncompatibleTypesInComparison: this is just a demo code
 if (id == 100) {
   // != means not equal to
   console.log('id == 100');
+  // deepcode ignore IncompatibleTypesInComparison: this is just a demo code
 } else if (id > 100) {
   console.log('id > 100');
 } else {
@@ -21,6 +23,7 @@ if (id === 100) {
   console.log('Not equal');
 }
 
+// deepcode ignore CompareTypeofToString: this is just a demo code
 if (typeof id !== undefined) {
   // test if something is undefined
   console.log(`ID is ${id}`);

javascript/01_basics/18_objects.js

@@ -41,6 +41,7 @@ const num1 = 5;
 const num2 = new Number(5); // not recommended
 
 const bool1 = true;
+// deepcode ignore BooleanObjectCreation: this is just a demo code
 const bool2 = new Boolean(true); // not recommended
 
 const getSum1 = function (x, y) {
@@ -55,6 +56,7 @@ const getSum2 = new Function('x', 'y', 'return x + y');
 console.log(getSum2(5, 10));
 
 const john1 = { name: 'John', age: 32 };
+// deepcode ignore ObjectConstructor: this is just a demo code
 const john2 = new Object({ name: 'John', age: 32 });
 
 console.log(john1);

javascript/01_basics/24_fetch_api.js

@@ -6,6 +6,7 @@ function getText() {
       return res.text();
     })
     .then(function (data) {
+      // deepcode ignore DOMXSS: this is just a demo code
       document.getElementById('output').innerHTML = `<h1>${data}</h1>`;
     })
     .catch(function (err) {
@@ -21,6 +22,7 @@ function getJSON() {
       return res.json();
     })
     .then(function (data) {
+      // deepcode ignore DOMXSS: this is just a demo code
       document.getElementById('output').innerHTML = `<h1>${data.name}</h1>`;
     })
     .catch(function (err) {
@@ -38,6 +40,7 @@ function getExternal() {
     .then(function (data) {
       document.getElementById(
         'output'
+        // deepcode ignore DOMXSS: this is just a demo code
       ).innerHTML = `<h1>${data.value.joke}</h1>`;
     })
     .catch(function (err) {

javascript/01_basics/25_arrow_functions.js

@@ -4,6 +4,7 @@ function getText() {
   fetch('25_arrow_functions.txt')
     .then((res) => res.text())
     .then((data) => {
+      // deepcode ignore DOMXSS: this is just a demo code
       document.getElementById('output').innerHTML = `<h1>${data}</h1>`;
     })
     .catch((err) => {
@@ -17,6 +18,7 @@ function getJSON() {
   fetch('25_arrow_functions.json')
     .then((res) => res.json())
     .then((data) => {
+      // file deepcode ignore DOMXSS: this is just a demo code
       document.getElementById('output').innerHTML = `<h1>${data.name}</h1>`;
     })
     .catch((err) => {
@@ -32,6 +34,7 @@ function getExternal() {
     .then((data) => {
       document.getElementById(
         'output'
+        // deepcode ignore DOMXSS: this is just a demo code
       ).innerHTML = `<h1>${data.value.joke}</h1>`;
     })
     .catch((err) => {

javascript/01_basics/26_async_await.js

@@ -4,4 +4,5 @@ async function myFunc() {
   return 'Hello';
 }
 
+// file deepcode ignore PromiseNotCaughtGeneral: this is just a demo code
 myFunc().then((data) => console.log(data));

javascript/01_basics/37_singleton_pattern.js

@@ -4,6 +4,7 @@ const Singleton = (function () {
   let instance;
 
   function createInstance() {
+    // file deepcode ignore ObjectConstructor: this is just a demo code
     const object = new Object('I am the instance');
     return object;
   }

javascript/01_basics/42_array_slicing/index.js

@@ -5,6 +5,7 @@ let morePrimes = [...primes, 13, 17, 19, 23, 29]; // An array with 10 numeric el
 let anything = [1.1, 'one', true]; // An array with 3 elements of different types
 let threeElements = [1, , 3]; // An array with 3 elements, 2nd element is undefined
 // Array Constructor
+// file deepcode ignore ArrayConstructor: this is just a demo code
 let array1 = new Array(); // An empty array, equivalent to []
 let array2 = new Array(10); // An array with 10 undefined elements
 // Array.of and Array.from

javascript/02_typescript/01_data_types/js/data_types.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 // TypeScript uses the same primitive data types as JavaScript
 // Boolean
 const isDone = false;
@@ -25,9 +25,9 @@ x = ['hello', 10]; // OK
 // Enum
 var Color;
 (function (Color) {
-    Color[Color["Red"] = 0] = "Red";
-    Color[Color["Green"] = 1] = "Green";
-    Color[Color["Blue"] = 2] = "Blue";
+  Color[(Color['Red'] = 0)] = 'Red';
+  Color[(Color['Green'] = 1)] = 'Green';
+  Color[(Color['Blue'] = 2)] = 'Blue';
 })(Color || (Color = {}));
 const c = Color.Green;
 // Any
@@ -36,14 +36,14 @@ notSure = 'maybe a string instead';
 notSure = false; // okay, definitely a boolean
 // Void
 function warnUser() {
-    console.log('This is my warning message');
+  console.log('This is my warning message');
 }
 // Null and Undefined
 let u = undefined;
 let n = null;
 // Never
 function error(message) {
-    throw new Error(message);
+  throw new Error(message);
 }
 create({ prop: 0 }); // OK
 create(null); // OK
@@ -60,27 +60,26 @@ let strLength2 = someValue.length;
 let someValue2 = 'this is a string';
 let strLength3 = someValue2.length;
 function getName(n) {
-    if (typeof n === 'string') {
-        return n;
-    }
-    else {
-        return n();
-    }
+  if (typeof n === 'string') {
+    return n;
+  } else {
+    return n();
+  }
 }
 function printLabel(labelledObj) {
-    console.log(labelledObj.label);
+  console.log(labelledObj.label);
 }
 let myObj = { size: 10, label: 'Size 10 Object' };
 printLabel(myObj);
 function createSquare(config) {
-    let newSquare = { color: 'white', area: 100 };
-    if (config.color) {
-        newSquare.color = config.color;
-    }
-    if (config.width) {
-        newSquare.area = config.width * config.width;
-    }
-    return newSquare;
+  let newSquare = { color: 'white', area: 100 };
+  if (config.color) {
+    newSquare.color = config.color;
+  }
+  if (config.width) {
+    newSquare.area = config.width * config.width;
+  }
+  return newSquare;
 }
 let mySquare = createSquare({ color: 'black' });
 console.log(mySquare);
@@ -90,104 +89,103 @@ let p1 = { x: 10, y: 20 };
 let a = [1, 2, 3, 4];
 let ro = a;
 function createSquare2(config) {
-    // ...
-    throw new Error('Not implemented');
+  // ...
+  throw new Error('Not implemented');
 }
 let mySearch;
 mySearch = function (source, subString) {
-    let result = source.search(subString);
-    return result > -1;
+  let result = source.search(subString);
+  return result > -1;
 };
 let myArray;
 myArray = ['Bob', 'Fred'];
 let myStr = myArray[0];
 class Clock {
-    setTime(d) {
-        this.currentTime = d;
-    }
-    constructor(h, m) {
-        this.currentTime = new Date();
-    }
+  setTime(d) {
+    this.currentTime = d;
+  }
+  constructor(h, m) {
+    this.currentTime = new Date();
+  }
 }
 let square = {};
 square.color = 'blue';
 square.sideLength = 10;
 function getCounter() {
-    let counter = function (start) { };
-    counter.interval = 123;
-    counter.reset = function () { };
-    return counter;
+  let counter = function (start) {};
+  counter.interval = 123;
+  counter.reset = function () {};
+  return counter;
 }
 let counter = getCounter();
 counter(10);
 counter.reset();
 counter.interval = 5.0;
 // Interfaces Extending Classes
-class Control {
-}
+class Control {}
 class Button extends Control {
-    select() { }
+  select() {}
 }
 class TextBox extends Control {
-    select() { }
+  select() {}
 }
 function getSmallPet() {
-    // ...
-    throw new Error('Not implemented');
+  // ...
+  throw new Error('Not implemented');
 }
+// file deepcode ignore UsageOfUndefinedReturnValue: this is just a demo code
 let pet = getSmallPet();
 pet.layEggs(); // okay
 // pet.swim();    // errors
 if (pet.swim) {
-    pet.swim();
-}
-else {
-    pet.fly();
+  pet.swim();
+} else {
+  pet.fly();
 }
 // typeof type guards
 function isNumber(x) {
-    return typeof x === 'number';
+  return typeof x === 'number';
 }
 function isString(x) {
-    return typeof x === 'string';
+  return typeof x === 'string';
 }
 function padLeft(value, padding) {
-    if (isNumber(padding)) {
-        return Array(padding + 1).join(' ') + value;
-    }
-    if (isString(padding)) {
-        return padding + value;
-    }
-    throw new Error(`Expected string or number, got '${padding}'.`);
+  if (isNumber(padding)) {
+    return Array(padding + 1).join(' ') + value;
+  }
+  if (isString(padding)) {
+    return padding + value;
+  }
+  throw new Error(`Expected string or number, got '${padding}'.`);
 }
 class SpaceRepeatingPadder {
-    constructor(numSpaces) {
-        this.numSpaces = numSpaces;
-    }
-    getPaddingString() {
-        return Array(this.numSpaces + 1).join(" ");
-    }
+  constructor(numSpaces) {
+    this.numSpaces = numSpaces;
+  }
+  getPaddingString() {
+    return Array(this.numSpaces + 1).join(' ');
+  }
 }
 class StringPadder {
-    constructor(value) {
-        this.value = value;
-    }
-    getPaddingString() {
-        return this.value;
-    }
+  constructor(value) {
+    this.value = value;
+  }
+  getPaddingString() {
+    return this.value;
+  }
 }
 function getRandomPadder() {
-    return Math.random() < 0.5 ?
-        new SpaceRepeatingPadder(4) :
-        new StringPadder("  ");
+  return Math.random() < 0.5
+    ? new SpaceRepeatingPadder(4)
+    : new StringPadder('  ');
 }
 // Type is 'SpaceRepeatingPadder | StringPadder'
 let padder = getRandomPadder();
 if (padder instanceof SpaceRepeatingPadder) {
-    padder; // type narrowed to 'SpaceRepeatingPadder'
+  padder; // type narrowed to 'SpaceRepeatingPadder'
 }
 if (padder instanceof StringPadder) {
-    padder; // type narrowed to 'StringPadder'
+  padder; // type narrowed to 'StringPadder'
 }
 // Nullable Types
 let s = 'foo';

javascript/02_typescript/03_unions_and_literals/unions_and_literals.ts

@@ -32,6 +32,7 @@ let admiral: number | string;
 
 admiral = 'Grace Hopper';
 
+// file deepcode ignore PureMethodReturnValueIgnored: this is just a demo code
 admiral.toUpperCase(); // Ok: string
 
 // admiral.toFixed();
@@ -51,6 +52,7 @@ let scientist = Math.random() > 0.5 ? 'Rosalind Franklin' : 51;
 
 if (scientist === 'Rosalind Franklin') {
   // Type of scientist: string
+  // file deepcode ignore StringMethodOnNonString: this is just a demo code
   scientist.toUpperCase(); // Ok
 }
 
@@ -125,6 +127,7 @@ let biologist = Math.random() > 0.5 && 'Rachel Carson';
 
 if (biologist) {
   biologist; // Type: string
+  // file deepcode ignore DuplicateIfBody: this is just a demo code
 } else {
   biologist; // Type: false | string
 }

projects/javascript/01_mini/01_easy_http/easyhttp.js

@@ -24,6 +24,7 @@ easyHttpWithXhrAndCallbacks.prototype.get = function (url, callback) {
 // Make an HTTP POST request
 easyHttpWithXhrAndCallbacks.prototype.post = function (url, data, callback) {
   this.http.open('POST', url, true);
+  // file deepcode ignore ContentTypeNoCharset: this is just a demo code
   this.http.setRequestHeader('Content-type', 'application/json');
 
   let self = this;

projects/javascript/05_book_list/js/main-es6.js

@@ -54,6 +54,7 @@ class UI {
 class Store {
   static displayBooks() {
     const books = Store.getBooks();
+    // file deepcode ignore DOMXSS: this is just a demo code
     books.forEach((book) => UI.addBookToList(book));
   }