Skip to content

Support enabling CORS with the use of an Environment Variable #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexgleith opened this issue Jul 27, 2022 · 2 comments
Closed

Support enabling CORS with the use of an Environment Variable #430

alexgleith opened this issue Jul 27, 2022 · 2 comments

Comments

@alexgleith
Copy link

Hey folks, love your work!

It would be great if we can do a few more common configuration things without needing to build a custom Docker image.

One important example is CORS. I know we can install the CORS Middleware for FastAPI, but what if we could run the Docker image with ENABLE_CORS=true or CORS_DOMAINS="*" and it just worked. That would be nice, right!

Thoughts?
@drnextgis
Copy link
Contributor

drnextgis commented Jul 27, 2022 •
edited
Loading

Have you seen this PR #341

@alexgleith
Copy link
Author

Duplicate, whoops. I'll comment on the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drnextgis @alexgleith