Skip to content

Examine if pr 442 introduces breaking changes #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonhealy1 opened this issue Mar 29, 2024 · 2 comments
Closed

Examine if pr 442 introduces breaking changes #644

jonhealy1 opened this issue Mar 29, 2024 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@jonhealy1
Copy link
Collaborator

Examine if merging pr 442 introduces breaking changes. If so, these changes should necessitate a v3.0.0 release next.

In the comments for this pr, @geospatial-jeff declares that his work introduces a breaking change, while @gadomski later puts forth the idea that it is not a breaking change and fine for a v2.5.0 release.

@jonhealy1 jonhealy1 changed the title Examine if pr [442](https://github.com/stac-utils/stac-fastapi/pull/442) introduced breaking changes Examine if pr 422 introduces breaking changes Mar 29, 2024
@jonhealy1 jonhealy1 changed the title Examine if pr 422 introduces breaking changes Examine if pr 442 introduces breaking changes Mar 29, 2024
@vincentsarago
Copy link
Member

I think some could argue that https://github.com/stac-utils/stac-fastapi/pull/442/files#diff-4f8c5fdc9b3cca78110705589c68a6df26ac7a9d66bd4af3108db5174fdfe49cR99 is a breaking change because we change the type of the middlewares attribute.

In practice, user can still pass middlewares=[BrotliMiddleware] or middlewares=[Middleware(BrotliMiddleware)]

@vincentsarago vincentsarago added the question Further information is requested label Apr 9, 2024
@vincentsarago vincentsarago added this to the 3.0.0 milestone Apr 10, 2024
@jonhealy1
Copy link
Collaborator Author

Closing this because we are merging #442 in v3.0.0 which is a major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants