Upgrades to bazel 7 #148
Open
Upgrades to bazel 7 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlazaro
commented
Aug 3, 2025
| # "coverage_test.go", | ||
| # "diff_test.go", | ||
| # "existing_scala_rule_test.go", | ||
| # "flags_test.go", |
There was a problem hiding this comment.
These seem like an accident as all are below.
tlazaro
commented
Aug 3, 2025
| @@ -608,7 +608,7 @@ test( | |||
| expr = "@@@", | |||
| ) | |||
| `, | |||
| want: label.NoLabel, | |||
| want: label.New("@", "", "@"), | |||
There was a problem hiding this comment.
I don't know why this test broke, making it pass for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add support for bzlmod, which uses the MODULE file instead of WORKSPACE. Both approaches can coexist but we first need to move to bazel 7.
Some dependencies required upgrading and tests needed some tweaks.
Let me know if this makes sense. While trying to implement the MODULE I ended up blocked by
stackbuild/rules_proto, where I saw you are migrating as well.