Skip to content

Stash a cover letter for a branch #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwd opened this issue May 2, 2018 · 4 comments
Open

Stash a cover letter for a branch #23

gwd opened this issue May 2, 2018 · 4 comments

Comments

@gwd
Copy link

gwd commented May 2, 2018

stg mail has the option of editing a cover letter and/or reading it in from a file, but if I'm working on several different series in parallel (and sending new iterations of each one), I'd like to be able to store a cover letter with the branch that I can just edit and update every time I send a new version. It seems like it would be pretty straightforward to have stg store it in .git/patches/$branch, and maybe edit it using a command like stg cover or something. That would solve the biggest missing piece of functionality wrt stackgit in my workflow.

@jpgrayson
Copy link
Collaborator

This idea makes sense to me. I appreciate you taking the time to write down this idea.

@gwd
Copy link
Author

gwd commented May 8, 2018

I appreciate you taking the time to maintain a tool that I use every day. :-)

@ctmarinas
Copy link
Member

It makes sense (I occasionally find that I need something similar, for example reworking a patch series and wanting to store some notes like changes from the previous version). The only comment I have on the original proposal is that it should be stored in the stgit metadata stored in the .stgit object. We've been trying for a while to get rid of .git/patches entirely.

@palves
Copy link

palves commented Apr 19, 2024

FWIW, I use "git branch --edit-description" for storing the branch's description for "git send-email --cover-letter".

I just now tried the same with "stg email send", and unfortunately, it doesn't know how to use the branch description as cover letter. Vis:

$ stg email send --all -G --cover-letter --to=[email protected]
/tmp/AsQX8xw8f3/0000-cover-letter.patch
/tmp/AsQX8xw8f3/0001-foo.patch
error: git send-email: Refusing to send because the patch
/tmp/AsQX8xw8f3/0000-cover-letter.patch
has the template subject '*** SUBJECT HERE ***'. Pass --force if you really want to send.

It'd be nice if "stg email send --cover" worked without -G, too, I guess.

(I realize the bug was probably open against stgit 1, while my comments above are for stgit 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants