Skip to content

Feature request: Can --sign/--ack/--review be given an email address as an optional parameter #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhowells opened this issue Jan 13, 2021 · 2 comments

Comments

@dhowells
Copy link

Can it be made such that stg edit --sign/--ack/--review can be given a parameter to indicate the address to be used instead of using the address of whoever's running the command? E.g.:

stg edit --sign="David Howells [email protected]"

@jpgrayson
Copy link
Collaborator

Under the hood, StGit uses optparse for options parsing which does not have built-in support for options with optional arguments. It may be possible to achieve this somehow, but it's not obvious to me how to do it.

A more straightforward alternative would be to have a parallel set of options that required an argument. For example, --sign-as, --ack-as, and --review-as. These could used in the normal manner of GNU-style options, i.e. either with or without =:

stg edit --sign-as="David Howells <[email protected]>" or
stg edit --sign-as "David Howells <[email protected]>"

I am open to a PR that either adds these new options or somehow figures out how to make an optional argument work with the existing options.

@dhowells
Copy link
Author

A separate parameter, eg. --sign-as, would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants