Skip to content

Forthcoming release of ggplot2 and bayesplot #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paleolimbot opened this issue May 14, 2019 · 1 comment
Closed

Forthcoming release of ggplot2 and bayesplot #189

paleolimbot opened this issue May 14, 2019 · 1 comment
Labels

Comments

@paleolimbot
Copy link

We are contacting you because you are the maintainer of bayesplot, which depends on ggplot2 and uses vdiffr to manage visual test cases. The upcoming release of ggplot2 includes several improvements to plot rendering, including the ability to specify lineend and linejoin in geom_rect() and geom_tile(), and improved rendering of text. These improvements will result in subtle changes to your vdiffr dopplegangers when the new version is released.

Because vdiffr test cases do not run on CRAN by default, your CRAN checks will still pass. However, we suggest updating your visual test cases with the new version of ggplot2 as soon as possible to avoid confusion. You can install the development version of ggplot2 using remotes::install_github("tidyverse/ggplot2").

If you have any questions, let me know!

@jgabry
Copy link
Member

jgabry commented May 14, 2019

Thanks for the heads up! I noticed that our vdiffr tests failed after I installed ggplot2 from GitHub last week, so I actually already went through and checked/updated all the cases in commit e2cc429. So I think we should be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants