[5.x] Fix editability of nav items without content reference #11822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
duncanmcclean
changed the title
…urls weren't getting through.
|
I’d say the PHP transformer is more for sending data, and the vue component is more for handling how things are displayed. After diving in, I saw we already had url fallback handling on the vue side too. Made that change for you. Also added edit option to twirldown, since we use that pattern in a lot of other places as well ❤️
|
jesseleite
approved these changes
May 29, 2025
jesseleite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it wasn't possible to edit nav items without titles, because there was no title/URL to click on.
When you add a nav item without a title, it'll fall back to the URL. However, when you refreshed the page, it would have just been blank.
Fixes #11818.