move rulesets cb location (#435)

moving rulesets callback to after the store has finished parsing and
updating, in case end user is expecting to evaluate right away using the
new configs

Author: kat-statsig

statsig/spec_store.py

@@ -143,6 +143,7 @@ def get_target_app_for_sdk_key(self, sdk_key=None):
 
     def get_default_environment(self):
         return self._default_environment
+
     def get_session_replay_info(self):
         return self._session_replay_info
 
@@ -170,9 +171,10 @@ def _process_specs(self, specs_json, source: DataSource) -> Tuple[bool, bool]:
         if specs_json.get("time", 0) < self.last_update_time():  # outdated lcut
             self._log_process("Failed to process specs, lcut is older than current lcut")
             return False, False
+
+        copy = None
         if callable(self._options.rules_updated_callback):
             copy = json.dumps(specs_json)
-            self._options.rules_updated_callback(copy)
 
         def get_parsed_specs(key: str):
             parsed = {}
@@ -267,6 +269,8 @@ def parse_target_value_map_from_spec(spec, parsed):
         sampling_rate = specs_json.get("diagnostics", {})
         self._diagnostics.set_sampling_rate(sampling_rate)
         self._log_process("Done processing specs")
+        if callable(self._options.rules_updated_callback):
+            self._options.rules_updated_callback(copy)
         return True, True
 
     def _process_download_id_lists(self, server_id_lists):

tests/test_eval_callback.py

@@ -1,14 +1,14 @@
-import time
+import json
 import os
+import time
 import unittest
-import json
-
-from typing import Optional, Union, Callable
-
+from typing import Union
 from unittest.mock import patch
+
 from gzip_helpers import GzipHelpers
 from network_stub import NetworkStub
-from statsig import statsig, StatsigUser, StatsigOptions, StatsigEvent, StatsigEnvironmentTier, DynamicConfig, Layer, FeatureGate
+from statsig import statsig, StatsigUser, StatsigOptions, StatsigEnvironmentTier, DynamicConfig, Layer, \
+    FeatureGate
 
 with open(os.path.join(os.path.abspath(os.path.dirname(__file__)), '../testdata/download_config_specs.json')) as r:
     CONFIG_SPECS_RESPONSE = r.read()
@@ -22,6 +22,7 @@ class TestEvalCallback(unittest.TestCase):
     _gateName = ""
     _configName = ""
     _layerName = ""
+    _spec_match = False
 
     @classmethod
     @patch('requests.request', side_effect=_network_stub.mock)
@@ -47,19 +48,24 @@ def log_event_callback(url: str, **kwargs):
             "regular_user_id", email="[email protected]", private_attributes={"test": 123})
         cls.random_user = StatsigUser("random")
         cls._logs = {}
+
         def callback_func(config: Union[DynamicConfig, FeatureGate, Layer]):
             if isinstance(config, FeatureGate):
                 cls._gateName = config.get_name()
             if isinstance(config, DynamicConfig):
                 cls._configName = config.get_name()
             if isinstance(config, Layer):
                 cls._layerName = config.get_name()
-                
+
+        def specs_callback(specs: str):
+            cls._spec_match = json.loads(specs) == json.loads(CONFIG_SPECS_RESPONSE)
+
         options = StatsigOptions(
             api=_network_stub.host,
             tier=StatsigEnvironmentTier.development,
             disable_diagnostics=True,
-            evaluation_callback=callback_func)
+            evaluation_callback=callback_func,
+            rules_updated_callback=specs_callback, )
 
         statsig.initialize("secret-key", options)
         cls.initTime = round(time.time() * 1000)
@@ -102,5 +108,9 @@ def test_c_experiment(self, mock_request):
             "a_layer"
         )
 
+    def test_d_spec_match(self, mock_request):
+        self.assertTrue(self._spec_match)
+
+
 if __name__ == '__main__':
     unittest.main()