fix: set accept-encoding header (#425)

#29

Author: tore-statsig

.github/workflows/test.yml

@@ -9,14 +9,17 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v2
         with:
           python-version: "3.8"
 
+      - name: Upgrade pip, setuptools, and wheel
+        run: python -m pip install --upgrade pip setuptools wheel
+
       - name: Install Deps
         run: |
           pip install --upgrade pylint

requirements.txt

@@ -1,5 +1,5 @@
 ip3country==0.3.0
-setuptools==78.1.1
+setuptools==75.3.2
 ua_parser==0.10.0
 user_agents==2.2.0
 grpcio==1.62.3

statsig/client_initialize_formatter.py

@@ -193,7 +193,7 @@ def map_fnc(entry):
                     hash_name(targeting_gate_name, hash_algo), None)
                 if targeting_gate is not None:
                     result["passes_session_recording_targeting"] = targeting_gate.get("value", False)
-                    if result["passes_session_recording_targeting"] != True:
+                    if not result["passes_session_recording_targeting"]:
                         can_record = False
             sampling_rate = session_replay_info.get("sampling_rate", None)
             rand = random.random()

statsig/http_worker.py

@@ -260,6 +260,7 @@ def _prepare_headers(self, headers: Optional[Dict[str, Any]], zipped: bool) -> D
             "STATSIG-SDK-TYPE": self.__statsig_metadata["sdkType"],
             "STATSIG-SDK-VERSION": self.__statsig_metadata["sdkVersion"],
             "STATSIG-RETRY": "0",
+            "Accept-Encoding": "gzip",
         }
         if zipped:
             base_headers.update({"Content-Encoding": "gzip"})

tests/test_sync_config_fallback.py

@@ -165,6 +165,25 @@ def test_fallback_when_dcs_incomplete_read_gzip(self, request_mock):
         self.get_gate_and_validate()
         self.wait_for_sync_and_validate()
 
+    def test_accept_encoding_header(self, mock_request):
+        headers_verified = False
+
+        def verify_headers(url, **kwargs):
+            nonlocal headers_verified
+            request_headers = kwargs.get('headers', {})
+            self.assertEqual(request_headers.get('Accept-Encoding'), 'gzip')
+            headers_verified = True
+            return PARSED_CONFIG_SPEC
+
+        _network_stub.stub_request_with_function(
+            "download_config_specs/.*", 200, verify_headers)
+
+        options = StatsigOptions(api=_network_stub.host)
+        statsig.initialize("secret-key", options)
+        statsig.shutdown()
+        
+        self.assertTrue(headers_verified, "Headers were not verified")
+
     def wait_for_sync_and_validate(self):
         _network_stub.stub_statsig_api_request_with_value("download_config_specs/.*", 200,
                                                           UPDATED_TIME_CONFIG_SPEC)