Some bug fixes (#359)

- id list was falling back regardless if fallback option was enabled
- response.text warning produce multiline logs in datadog, its not very
informative anyways so removing
- do not check store populated on local mode
- do not sample override 
- in output logger unit test, log_process should have used debug like it
does in normal output logger, so the number of logs are off
- if using multi instance, StatsigServer.initialize() allow the options
to be optional, if its none/incorrect type, create empty statsigOptions
to not break downstream.

Author: kat-statsig

statsig/http_worker.py

@@ -211,10 +211,9 @@ def request_task():
                 globals.logger.warning(
                     f"Request to {url} failed with code {response.status_code}"
                 )
-                globals.logger.warning(response.text)
             return response
         except Exception as err:
-            globals.logger.debug(f"Request to {url} failed with error {err}")
+            globals.logger.warning(f"Request to {url} failed with error {err}")
             if create_marker is not None:
                 self.__diagnostics.add_marker(
                     create_marker().end(
@@ -235,6 +234,7 @@ def request_task():
                     "request:" + tag,
                     err,
                     {"timeoutMs": timeout * 1000, "httpMethod": method},
+                    log_mode="none",
                 )
             return None
 

statsig/spec_updater.py

@@ -250,7 +250,7 @@ def on_complete(id_lists: list, error: Exception):
                 init_timeout = self._options.init_timeout
 
             self._network.get_id_lists(on_complete, False, init_timeout)
-            if result[0] is False:
+            if result[0] is False and self._options.fallback_to_statsig_api:
                 self._network.get_id_lists_fallback(on_complete, False, init_timeout)
 
         except Exception as e:

statsig/statsig_error_boundary.py

@@ -78,7 +78,7 @@ def log_exception(
             exception: Exception,
             extra: Optional[dict] = None,
             bypass_dedupe: bool = False,
-            log_mode: Optional[str] = "warning",  # warn/debug based on error severity
+            log_mode: Optional[str] = "warning",  # warn/debug/none based on error severity
     ):
         try:
             stack_trace = traceback.format_exc()

statsig/statsig_network.py

@@ -169,7 +169,7 @@ def get_dcs_fallback(
             init_timeout: Optional[int] = None,
     ):
         if self.statsig_options.local_mode:
-            globals.logger.warning("Local mode is enabled. Not fetching DCS.")
+            globals.logger.warning("Local mode is enabled. Not fetching DCS with fallback.")
             return
         dcs_proxy = self.statsig_options.proxy_configs.get(NetworkEndpoint.DOWNLOAD_CONFIG_SPECS)
         is_proxy_dcs = (
@@ -198,7 +198,7 @@ def get_id_lists_fallback(
             init_timeout: Optional[int] = None,
     ):
         if self.statsig_options.local_mode:
-            globals.logger.warning("Local mode is enabled. Not fetching ID Lists.")
+            globals.logger.warning("Local mode is enabled. Not fetching ID Lists with fallback.")
             return
         if not self.statsig_options.fallback_to_statsig_api:
             return

statsig/statsig_server.py

@@ -78,13 +78,28 @@ def initialize(self, sdkKey: str, options: Optional[StatsigOptions] = None) -> I
                 "Invalid key provided. You must use a Server Secret Key from the Statsig console."
             )
 
-        environment_tier = options.get_sdk_environment_tier() if isinstance(options, StatsigOptions) else 'unknown'
+        if options is None or not isinstance(options, StatsigOptions):
+            options = StatsigOptions()
+
+        environment_tier = options.get_sdk_environment_tier() or 'unknown'
         globals.logger.info(
             f"Initializing Statsig SDK (v{__version__}) instance. "
             f"Current environment tier: {environment_tier}."
         )
 
         init_details = self._initialize_impl(sdkKey, options)
+        self._post_init_logging(options, init_details)
+
+        return init_details
+
+    def _post_init_logging(self, options: StatsigOptions, init_details: InitializeDetails):
+        if options.local_mode:
+            if init_details.init_success:
+                globals.logger.info(
+                    "Statsig SDK instance initialized in local mode. No data will be fetched from the Statsig servers.")
+            else:
+                globals.logger.error("Statsig SDK instance failed to initialize in local mode.")
+            return
 
         if init_details.init_success:
             if init_details.store_populated:
@@ -96,8 +111,6 @@ def initialize(self, sdkKey: str, options: Optional[StatsigOptions] = None) -> I
         else:
             globals.logger.error("Statsig SDK instance Initialized failed!")
 
-        return init_details
-
     def _initialize_impl(self, sdk_key: str, options: Optional[StatsigOptions]):
         threw_error = False
         try:
@@ -601,6 +614,9 @@ def __determine_sampling(self, type: EntityType, name: str, result: _ConfigEvalu
             if result.forward_all_exposures:
                 return True, None, None
 
+            if result.rule_id.endswith((':override', ':id_override')):
+                return True, None, None
+
             samplingSetKey = f"{name}_{result.rule_id}"
             if not self._sampling_key_set.contains(samplingSetKey):
                 self._sampling_key_set.add(samplingSetKey)

tests/test_output_logger.py

@@ -20,7 +20,7 @@ def __init__(self):
 
     def log_process(self, process: str, msg: str):
         message = sanitize(f"{process}: {msg}")
-        self.info(message)
+        self.debug(message)
 
     def debug(self, msg, *args, **kwargs):
         if self._logger.isEnabledFor(logging.DEBUG) and not self._disabled:
@@ -88,15 +88,15 @@ def test_initialize_timeout(self, mock_request):
         options = StatsigOptions(api=_network_stub.host, init_timeout=0.1, disable_diagnostics=True,
                                  custom_logger=logger)
         statsig.initialize("secret-key", options)
-        self.assertGreater(len(logger._logs.get("info")), 3)
+        self.assertGreaterEqual(len(logger._logs.get("info")), 2)
 
     @patch('requests.request', side_effect=_network_stub.mock)
     def test_initialize_failed_to_load_network_info(self, mock_request):
         logger = MockOutputLogger()
         logger.set_log_level(LogLevel.INFO)
         options = StatsigOptions(api=_network_stub.host, disable_diagnostics=True, custom_logger=logger)
         statsig.initialize("secret-key", options)
-        self.assertGreater(len(logger._logs.get("info")), 2)
+        self.assertGreaterEqual(len(logger._logs.get("info")), 2)
         self.assertGreater(len(logger._logs.get("warning")), 0)
         failed_urls = logger.check_urls_for_secret('secret-key')
         self.assertEqual(len(failed_urls), 0)
@@ -119,7 +119,7 @@ def test_set_logging_level_debug(self, mock_request):
         options = StatsigOptions(api=_network_stub.host, disable_diagnostics=True, custom_logger=logger)
         statsig.initialize("secret-key", options)
         self.assertGreater(len(logger._logs.get("debug")), 0)
-        self.assertGreater(len(logger._logs.get("info")), 2)
+        self.assertGreater(len(logger._logs.get("info")), 0)
         self.assertGreater(len(logger._logs.get("warning")), 0)
         failed_urls = logger.check_urls_for_secret('secret-key')
         self.assertEqual(len(failed_urls), 0)

tests/test_statsig_error_boundary_usage.py

@@ -1,12 +1,12 @@
 import unittest
+from unittest.mock import patch
 
 from statsig.dynamic_config import DynamicConfig
 from statsig.layer import Layer
-from statsig.spec_updater import SpecUpdater
 from statsig.statsig_event import StatsigEvent
+from statsig.statsig_options import StatsigOptions
 from statsig.statsig_server import StatsigServer
 from statsig.statsig_user import StatsigUser
-from unittest.mock import patch
 
 
 def mocked_post(*args, **kwargs):
@@ -63,12 +63,12 @@ def tearDown(self) -> None:
     def test_errors_with_initialize(self, mock_post):
         statsig = StatsigServer()
         TestStatsigErrorBoundaryUsage.requests = []
-        statsig.initialize("secret-key", "_BAD_OPTIONS_")
+        statsig.initialize("secret-key", StatsigOptions(proxy_configs="proxy_configs"))
 
         self.assertEqual(len(_get_requests(statsig)), 1)
         trace = _get_requests(self._instance)[0]['body']['info']
         self.assertIn(
-            "AttributeError: 'str' object has no attribute \'proxy_configs\'", trace)
+            "AttributeError: \'str\' object has no attribute \'get\'", trace)
         self.assertTrue(statsig._initialized)
 
     def test_errors_with_check_gate(self, mock_post):