fix sampling (#413)

added new condition in kong test
statsig-io/kong#3487

![Screenshot 2025-03-03 at 3 09
14 PM](https://github.com/user-attachments/assets/6c17a7be-c883-4dca-9889-eed4bf38502e)

Author: kat-statsig

statsig/config_evaluation.py

@@ -17,7 +17,10 @@ def __init__(self,
                  sample_rate=None,
                  user=None,
                  forward_all_exposures=False,
-                 id_type=""):
+                 id_type="",
+                 analytical_condition=False,
+                 seen_analytical_gates=False
+        ):
         if boolean_value is None:
             boolean_value = False
         self.boolean_value = boolean_value
@@ -45,3 +48,5 @@ def __init__(self,
         self.user = user
         self.forward_all_exposures = forward_all_exposures
         self.version = version
+        self.analytical_condition = analytical_condition
+        self.seen_analytical_gates = seen_analytical_gates

statsig/evaluator.py

@@ -303,7 +303,7 @@ def __finalize_exposures(self, end_result):
     def __evaluate_rule(self, user, rule, end_result):
         total_eval_result = True
         for condition in rule.get("conditions", []):
-            eval_result = self.__evaluate_condition(user, condition, end_result)
+            eval_result = self.__evaluate_condition(user, condition, end_result, rule.get("samplingRate", None))
             if not eval_result:
                 total_eval_result = False
         end_result.boolean_value = total_eval_result
@@ -325,13 +325,14 @@ def __evaluate_delegate(self, user, rule, end_result):
         end_result.allocated_experiment = config_delegate
         return end_result
 
-    def __evaluate_condition(self, user, condition, end_result):
+    def __evaluate_condition(self, user, condition, end_result, sampling_rate=None):
         value = None
         type = condition.get("type", "").upper()
         target = condition.get("targetValue")
         field = condition.get("field", "")
         id_Type = condition.get("idType", "userID")
         if type == "PUBLIC":
+            end_result.analytical_condition = sampling_rate is None
             return True
         if type in ("FAIL_GATE", "PASS_GATE"):
             self.check_gate(user, target, end_result, True)
@@ -343,11 +344,16 @@ def __evaluate_condition(self, user, condition, end_result):
             }
 
             end_result.secondary_exposures.append(new_exposure)
+            if end_result.analytical_condition and isinstance(target, str) and not target.startswith("segment:"):
+                end_result.seen_analytical_gates = True
 
             pass_gate = end_result.boolean_value if type == "PASS_GATE" else not end_result.boolean_value
+
+            end_result.analytical_condition = sampling_rate is None
             return pass_gate
         if type in ("MULTI_PASS_GATE", "MULTI_FAIL_GATE"):
             if target is None or len(target) == 0:
+                end_result.analytical_condition = sampling_rate is None
                 return False
             pass_gate = False
             for gate in target:
@@ -359,10 +365,14 @@ def __evaluate_condition(self, user, condition, end_result):
                     "ruleID": other_result.rule_id
                 }
                 end_result.secondary_exposures.append(new_exposure)
+                if end_result.analytical_condition and isinstance(target, str) and not target.startswith("segment:"):
+                    end_result.seen_analytical_gates = True
 
                 pass_gate = pass_gate or other_result.boolean_value if type == "MULTI_PASS_GATE" else pass_gate or not other_result.boolean_value
                 if pass_gate:
                     break
+
+            end_result.analytical_condition = sampling_rate is None
             return pass_gate
         if type == "IP_BASED":
             value = self.__get_from_user(user, field)
@@ -373,6 +383,7 @@ def __evaluate_condition(self, user, condition, end_result):
                         self._country_lookup = CountryLookup()
                     value = self._country_lookup.lookupStr(ip)
             if value is None:
+                end_result.analytical_condition = sampling_rate is None
                 return False
         elif type == "UA_BASED":
             value = self.__get_from_user(user, field)
@@ -394,6 +405,8 @@ def __evaluate_condition(self, user, condition, end_result):
         elif type == "UNIT_ID":
             value = self.__get_unit_id(user, id_Type)
 
+        end_result.analytical_condition = sampling_rate is None
+
         op = condition.get("operator")
         user_bucket = condition.get("user_bucket")
         if op == "gt":

statsig/statsig_logger.py

@@ -277,6 +277,9 @@ def __determine_sampling(self, type: EntityType, name: str, result: _ConfigEvalu
                 self._sampling_key_set.add(samplingSetKey)
                 return True, None, None
 
+            if result.seen_analytical_gates:
+                return True, None, None
+
             should_sample = result.sample_rate is not None or result.rule_id in special_case_rules
             if not should_sample:
                 return True, None, None