fix no update bug (#382)

fix bug where failed streaming returns default empty {} which gets
parsed as no update and do not trigger fallback on config syncs

Author: kat-statsig

statsig/http_worker.py

@@ -55,7 +55,7 @@ def get_dcs(self, on_complete: Callable, since_time=0, log_on_exception=False, i
             tag="download_config_specs")
         self._context.source_api = self.__api_for_download_config_specs
         if response is not None and self._is_success_code(response.status_code):
-            on_complete(DataSource.NETWORK, self._stream_response_into_result_dict(response) or {}, None)
+            on_complete(DataSource.NETWORK, self._stream_response_into_result_dict(response), None)
             return
         on_complete(DataSource.NETWORK, None, None)
 
@@ -66,7 +66,7 @@ def get_dcs_fallback(self, on_complete: Callable, since_time=0, log_on_exception
             tag="download_config_specs")
         self._context.source_api = STATSIG_CDN
         if response is not None and self._is_success_code(response.status_code):
-            on_complete(DataSource.STATSIG_NETWORK, self._stream_response_into_result_dict(response) or {}, None)
+            on_complete(DataSource.STATSIG_NETWORK, self._stream_response_into_result_dict(response), None)
             return
         on_complete(DataSource.STATSIG_NETWORK, None, None)
 
@@ -80,7 +80,7 @@ def get_id_lists(self, on_complete: Callable, log_on_exception=False, init_timeo
             tag="get_id_lists",
         )
         if response is not None and self._is_success_code(response.status_code):
-            return on_complete(self._stream_response_into_result_dict(response) or {}, None)
+            return on_complete(self._stream_response_into_result_dict(response), None)
         return on_complete(None, None)
 
     def get_id_lists_fallback(self, on_complete: Callable, log_on_exception=False, init_timeout=None):
@@ -93,7 +93,7 @@ def get_id_lists_fallback(self, on_complete: Callable, log_on_exception=False, i
             tag="get_id_lists",
         )
         if response is not None and self._is_success_code(response.status_code):
-            return on_complete(self._stream_response_into_result_dict(response) or {}, None)
+            return on_complete(self._stream_response_into_result_dict(response), None)
         return on_complete(None, None)
 
     def get_id_list(self, on_complete, url, headers, log_on_exception=False):

statsig/spec_store.py

@@ -154,7 +154,7 @@ def _initialize_specs(self):
     def _process_specs(self, specs_json, source: DataSource) -> Tuple[bool, bool]:  # has update, parse success
         self._log_process("Processing specs...")
         prev_lcut = self.spec_updater.last_update_time
-        if specs_json.get("has_updates", False) is False:
+        if specs_json.get("has_updates") is not None and not specs_json.get("has_updates"):
             globals.logger.log_config_sync_update(self.spec_updater.initialized, False,
                                                   self.spec_updater.last_update_time,
                                                   prev_lcut,
@@ -381,6 +381,6 @@ def _get_initialize_strategy(self) -> List[DataSource]:
             return strategies
         except Exception:
             globals.logger.warning(
-                "Failed to get initialization sources, fallling back to always sync from statsig network "
+                "Failed to get initialization sources, falling back to always sync from statsig network "
             )
             return [DataSource.STATSIG_NETWORK]

tests/test_telemetry_logger.py

@@ -92,7 +92,7 @@ def test_initialize_timeout(self, mock_request):
 
     def test_no_update_counter(self, mock_request):
         _network_stub.stub_request_with_value(
-            "download_config_specs/.*", 200, {"has_updated": False})
+            "download_config_specs/.*", 200, {"has_updates": False})
         ob_client = MockObservabilityClient()
         options = StatsigOptions(api=_network_stub.host, observability_client=ob_client, rulesets_sync_interval=0.5)
         statsig.initialize("secret-key", options)