Skip to content

#each block with single line comment between function call and a component inside it causes eslint to hang #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
DetachHead opened this issue Dec 19, 2022 · 1 comment

Comments

@DetachHead
Copy link
Contributor

DetachHead commented Dec 19, 2022

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.

What version of ESLint are you using?

8.30.0

What version of eslint-plugin-svelte are you using?

2.14.1

What did you do?

Configuration

n/a, see playground link

{#each a(
//
a) as a}
<A/>{/each}

What did you expect to happen?

eslint finishes checking the code in a timely manner

What actually happened?

eslint hangs

Link to GitHub Repo with Minimal Reproducible Example

https://ota-meshi.github.io/eslint-plugin-svelte/playground/#eJyrVkrOT0lVslKqVk5NTM5QSNSIydPXj8lL1FRILFZIrI3Js3HUt6vWB0nWKtUCAGG/Dwg=

Additional comments

@ota-meshi
Copy link
Member

Thank you for this issue!
This issue seems to be fixed in sveltejs/svelte-eslint-parser#262. Previous wrong AST caused an infinite loop within ESLint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants