visitor

Author: trueadm

packages/svelte/src/internal/client/runtime.js

@@ -419,10 +419,15 @@ function remove_reaction(signal, dependency) {
 export function remove_reactions(signal, start_index) {
 	const dependencies = signal.deps;
 	if (dependencies !== null) {
-		const active_dependencies = start_index === 0 ? null : dependencies.slice(0, start_index);
+		var active_dependencies = start_index === 0 ? null : dependencies.slice(0, start_index);
+		var visited = new Set();
 		let i;
 		for (i = start_index; i < dependencies.length; i++) {
 			const dependency = dependencies[i];
+			if (visited.has(dependency)) {
+				continue;
+			}
+			visited.add(dependency);
 			// Avoid removing a reaction if we know that it is active (start_index will not be 0)
 			if (active_dependencies === null || !active_dependencies.includes(dependency)) {
 				remove_reaction(signal, dependency);
@@ -770,14 +775,11 @@ export function get(signal) {
 		} else if (
 			dependencies === null ||
 			current_dependencies_index === 0 ||
-			(dependencies[current_dependencies_index - 1] !== signal && !dependencies.includes(signal))
+			dependencies[current_dependencies_index - 1] !== signal
 		) {
 			if (current_dependencies === null) {
 				current_dependencies = [signal];
-			} else if (
-				current_dependencies[current_dependencies.length - 1] !== signal &&
-				!current_dependencies.includes(signal)
-			) {
+			} else if (current_dependencies[current_dependencies.length - 1] !== signal) {
 				current_dependencies.push(signal);
 			}
 		}

packages/svelte/tests/signals/test.ts

@@ -572,30 +572,4 @@ describe('signals', () => {
 			assert.equal(d.deps?.length, 1);
 		};
 	});
-
-	test('reactions should not have duplicate dependencies', () => {
-		let state = proxy({
-			a: 1,
-			b: 2
-		});
-		let count = source(0);
-
-		return () => {
-			const effect = render_effect(() => {
-				state.a;
-				state.b;
-				if ($.get(count) > 0) {
-					state.a;
-					state.b;
-				}
-			});
-
-			flushSync();
-			assert.equal(effect?.deps?.length, 3);
-
-			set(count, 1);
-			flushSync();
-			assert.equal(effect?.deps?.length, 3);
-		};
-	});
 });