Skip to content

Commit ecf81b9

Browse files
bfangerBob Fanger
authored andcommitted
fix: Parameters with default values are optional
1 parent b56829c commit ecf81b9

File tree

2 files changed

+38
-38
lines changed

2 files changed

+38
-38
lines changed

src/runtime/animate/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ export interface AnimationConfig {
1111
}
1212

1313
interface FlipParams {
14-
delay: number;
15-
duration: number | ((len: number) => number);
16-
easing: (t: number) => number;
14+
delay?: number;
15+
duration?: number | ((len: number) => number);
16+
easing?: (t: number) => number;
1717
}
1818

1919
export function flip(node: Element, animation: { from: DOMRect; to: DOMRect }, params: FlipParams): AnimationConfig {

src/runtime/transition/index.ts

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ export interface TransitionConfig {
1212
}
1313

1414
interface BlurParams {
15-
delay: number;
16-
duration: number;
15+
delay?: number;
16+
duration?: number;
1717
easing?: EasingFunction;
18-
amount: number;
19-
opacity: number;
18+
amount?: number;
19+
opacity?: number;
2020
}
2121

2222
export function blur(node: Element, {
@@ -25,7 +25,7 @@ export function blur(node: Element, {
2525
easing = cubicInOut,
2626
amount = 5,
2727
opacity = 0
28-
}: BlurParams): TransitionConfig {
28+
}: BlurParams = {}): TransitionConfig {
2929
const style = getComputedStyle(node);
3030
const target_opacity = +style.opacity;
3131
const f = style.filter === 'none' ? '' : style.filter;
@@ -41,16 +41,16 @@ export function blur(node: Element, {
4141
}
4242

4343
interface FadeParams {
44-
delay: number;
45-
duration: number;
46-
easing: EasingFunction;
44+
delay?: number;
45+
duration?: number;
46+
easing?: EasingFunction;
4747
}
4848

4949
export function fade(node: Element, {
5050
delay = 0,
5151
duration = 400,
5252
easing = linear
53-
}: FadeParams): TransitionConfig {
53+
}: FadeParams = {}): TransitionConfig {
5454
const o = +getComputedStyle(node).opacity;
5555

5656
return {
@@ -62,12 +62,12 @@ export function fade(node: Element, {
6262
}
6363

6464
interface FlyParams {
65-
delay: number;
66-
duration: number;
67-
easing: EasingFunction;
68-
x: number;
69-
y: number;
70-
opacity: number;
65+
delay?: number;
66+
duration?: number;
67+
easing?: EasingFunction;
68+
x?: number;
69+
y?: number;
70+
opacity?: number;
7171
}
7272

7373
export function fly(node: Element, {
@@ -77,7 +77,7 @@ export function fly(node: Element, {
7777
x = 0,
7878
y = 0,
7979
opacity = 0
80-
}: FlyParams): TransitionConfig {
80+
}: FlyParams = {}): TransitionConfig {
8181
const style = getComputedStyle(node);
8282
const target_opacity = +style.opacity;
8383
const transform = style.transform === 'none' ? '' : style.transform;
@@ -95,16 +95,16 @@ export function fly(node: Element, {
9595
}
9696

9797
interface SlideParams {
98-
delay: number;
99-
duration: number;
100-
easing: EasingFunction;
98+
delay?: number;
99+
duration?: number;
100+
easing?: EasingFunction;
101101
}
102102

103103
export function slide(node: Element, {
104104
delay = 0,
105105
duration = 400,
106106
easing = cubicOut
107-
}: SlideParams): TransitionConfig {
107+
}: SlideParams = {}): TransitionConfig {
108108
const style = getComputedStyle(node);
109109
const opacity = +style.opacity;
110110
const height = parseFloat(style.height);
@@ -133,11 +133,11 @@ export function slide(node: Element, {
133133
}
134134

135135
interface ScaleParams {
136-
delay: number;
137-
duration: number;
138-
easing: EasingFunction;
139-
start: number;
140-
opacity: number;
136+
delay?: number;
137+
duration?: number;
138+
easing?: EasingFunction;
139+
start?: number;
140+
opacity?: number;
141141
}
142142

143143
export function scale(node: Element, {
@@ -146,7 +146,7 @@ export function scale(node: Element, {
146146
easing = cubicOut,
147147
start = 0,
148148
opacity = 0
149-
}: ScaleParams): TransitionConfig {
149+
}: ScaleParams = {}): TransitionConfig {
150150
const style = getComputedStyle(node);
151151
const target_opacity = +style.opacity;
152152
const transform = style.transform === 'none' ? '' : style.transform;
@@ -166,18 +166,18 @@ export function scale(node: Element, {
166166
}
167167

168168
interface DrawParams {
169-
delay: number;
170-
speed: number;
171-
duration: number | ((len: number) => number);
172-
easing: EasingFunction;
169+
delay?: number;
170+
speed?: number;
171+
duration?: number | ((len: number) => number);
172+
easing?: EasingFunction;
173173
}
174174

175175
export function draw(node: SVGElement & { getTotalLength(): number }, {
176176
delay = 0,
177177
speed,
178178
duration,
179179
easing = cubicInOut
180-
}: DrawParams): TransitionConfig {
180+
}: DrawParams = {}): TransitionConfig {
181181
const len = node.getTotalLength();
182182

183183
if (duration === undefined) {
@@ -199,9 +199,9 @@ export function draw(node: SVGElement & { getTotalLength(): number }, {
199199
}
200200

201201
interface CrossfadeParams {
202-
delay: number;
203-
duration: number | ((len: number) => number);
204-
easing: EasingFunction;
202+
delay?: number;
203+
duration?: number | ((len: number) => number);
204+
easing?: EasingFunction;
205205
}
206206

207207
type ClientRectMap = Map<any, { rect: ClientRect }>;
@@ -212,7 +212,7 @@ export function crossfade({ fallback, ...defaults }: CrossfadeParams & {
212212
const to_receive: ClientRectMap = new Map();
213213
const to_send: ClientRectMap = new Map();
214214

215-
function crossfade(from: ClientRect, node: Element, params: CrossfadeParams): TransitionConfig {
215+
function crossfade(from: ClientRect, node: Element, params: CrossfadeParams = {}): TransitionConfig {
216216
const {
217217
delay = 0,
218218
duration = d => Math.sqrt(d) * 30,

0 commit comments

Comments
 (0)