Skip to content

Svelte 5: flip reordering animation glitches (REOPEN) #10493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hakoomen opened this issue Feb 16, 2024 · 5 comments
Closed

Svelte 5: flip reordering animation glitches (REOPEN) #10493

hakoomen opened this issue Feb 16, 2024 · 5 comments

Comments

@hakoomen
Copy link

Describe the bug

This issue already exited(#9805) and was fixed and closed. But the animation glitches are still present and the REPLs in the original issue still have the animation problems mentioned in the issue.

Reproduction

  • see the original fixed issue REPLs

Logs

No response

System Info

REPL - Svelte

Severity

blocking an upgrade

@hakoomen hakoomen changed the title Svelte 5: flip reordering causes duplication and glitches (REOPEN) Svelte 5: flip reordering animation glitches (REOPEN) Feb 16, 2024
@dummdidumm dummdidumm added this to the 5.0 milestone Feb 16, 2024
@JVariance
Copy link

Also see this example (found on Discord, code by dominikg):
Svelte 4
Svelte 5

@thebjorn
Copy link

thebjorn commented Mar 7, 2024

Also see this example (found on Discord, code by dominikg):
Svelte 4
Svelte 5

I'm seeing glitches in both 4 and 5 in those examples:

Svelte 4: animation of the first element under the drag is sometimes missing a duration. To reproduce drag an element very slowly upwards, the first box drops down very fast while the rest have a pleasing slide into place. Sometimes the dragged element follows the dropping first element before bouncing back to the cursor.

Svelte 5: the banana bounces. It is originally the first element, but it continues to bounce regardless of which position it is dragged to. The drop and movement of the dragged element seems to be universally present.

@JonathonRP
Copy link

Would this also affect something like svelte 4 component animation library handling drag n drop?

@FoHoOV
Copy link
Contributor

FoHoOV commented Mar 28, 2024

It is fixed in the latest version (v.next85) (I guess because of this?). Also closes #10675.

@hakoomen
Copy link
Author

Yep, as @FoHoOV says it is fixed now. @trueadm maybe you want to also mention it in the release notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants