From c1eac6bb110e4b7b294367ad5c5c4f62f31351b2 Mon Sep 17 00:00:00 2001 From: Gautier Date: Tue, 20 Aug 2024 14:09:49 +0200 Subject: [PATCH 1/4] fix: small legibility improvement --- packages/svelte/src/index.d.ts | 2 +- packages/svelte/types/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/svelte/src/index.d.ts b/packages/svelte/src/index.d.ts index 802dfbc79036..2f4f39a3b78c 100644 --- a/packages/svelte/src/index.d.ts +++ b/packages/svelte/src/index.d.ts @@ -286,7 +286,7 @@ export interface Snippet { // in the future, the condition can be removed. ...args: number extends Parameters['length'] ? never : Parameters ): typeof SnippetReturn & { - _: 'functions passed to {@render ...} tags must use the `Snippet` type imported from "svelte"'; + _: "functions passed to {@render ...} tags must use the `Snippet` type imported from 'svelte'"; }; } diff --git a/packages/svelte/types/index.d.ts b/packages/svelte/types/index.d.ts index 36f7a9722995..4a563f415143 100644 --- a/packages/svelte/types/index.d.ts +++ b/packages/svelte/types/index.d.ts @@ -283,7 +283,7 @@ declare module 'svelte' { // in the future, the condition can be removed. ...args: number extends Parameters['length'] ? never : Parameters ): typeof SnippetReturn & { - _: 'functions passed to {@render ...} tags must use the `Snippet` type imported from "svelte"'; + _: "functions passed to {@render ...} tags must use the `Snippet` type imported from 'svelte'"; }; } From c6f9bad61beec2a34b6e70994dbfd770d466716a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= <48261497+GauBen@users.noreply.github.com> Date: Tue, 20 Aug 2024 17:34:01 +0200 Subject: [PATCH 2/4] Create rich-ladybugs-admire.md --- .changeset/rich-ladybugs-admire.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/rich-ladybugs-admire.md diff --git a/.changeset/rich-ladybugs-admire.md b/.changeset/rich-ladybugs-admire.md new file mode 100644 index 000000000000..b8e5afd97cd5 --- /dev/null +++ b/.changeset/rich-ladybugs-admire.md @@ -0,0 +1,5 @@ +--- +"svelte": patch +--- + +fix: small legibility improvement From 99691a998e0621db7c2257035ade725e6cbab972 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gautier=20Ben=20A=C3=AFm?= <48261497+GauBen@users.noreply.github.com> Date: Tue, 20 Aug 2024 17:34:48 +0200 Subject: [PATCH 3/4] Update rich-ladybugs-admire.md --- .changeset/rich-ladybugs-admire.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/rich-ladybugs-admire.md b/.changeset/rich-ladybugs-admire.md index b8e5afd97cd5..f86504313d6f 100644 --- a/.changeset/rich-ladybugs-admire.md +++ b/.changeset/rich-ladybugs-admire.md @@ -2,4 +2,4 @@ "svelte": patch --- -fix: small legibility improvement +fix: small legibility improvement in `Snippet` type hint From 090600b45694bc0bad5b12842432693bb9540cd1 Mon Sep 17 00:00:00 2001 From: Gautier Date: Tue, 20 Aug 2024 17:43:34 +0200 Subject: [PATCH 4/4] even better? --- packages/svelte/src/index.d.ts | 6 +++--- packages/svelte/types/index.d.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/svelte/src/index.d.ts b/packages/svelte/src/index.d.ts index 2f4f39a3b78c..79d048b81584 100644 --- a/packages/svelte/src/index.d.ts +++ b/packages/svelte/src/index.d.ts @@ -285,9 +285,9 @@ export interface Snippet { // rest parameter type, which is not supported. If rest parameters are added // in the future, the condition can be removed. ...args: number extends Parameters['length'] ? never : Parameters - ): typeof SnippetReturn & { - _: "functions passed to {@render ...} tags must use the `Snippet` type imported from 'svelte'"; - }; + ): { + '{@render ...} must be called with a Snippet': "import type { Snippet } from 'svelte'"; + } & typeof SnippetReturn; } interface DispatchOptions { diff --git a/packages/svelte/types/index.d.ts b/packages/svelte/types/index.d.ts index 4a563f415143..881642e746ff 100644 --- a/packages/svelte/types/index.d.ts +++ b/packages/svelte/types/index.d.ts @@ -282,9 +282,9 @@ declare module 'svelte' { // rest parameter type, which is not supported. If rest parameters are added // in the future, the condition can be removed. ...args: number extends Parameters['length'] ? never : Parameters - ): typeof SnippetReturn & { - _: "functions passed to {@render ...} tags must use the `Snippet` type imported from 'svelte'"; - }; + ): { + '{@render ...} must be called with a Snippet': "import type { Snippet } from 'svelte'"; + } & typeof SnippetReturn; } interface DispatchOptions {