From f8463f833c87e4eb3b90f80fa79bde4e8d50b381 Mon Sep 17 00:00:00 2001
From: Conduitry <git@chor.date>
Date: Sun, 8 Jul 2018 01:47:38 -0400
Subject: [PATCH] fix determing whether an attribute should prevent innerHTML
 optimization

Fixes #1581
---
 src/compile/nodes/Element.ts                              | 8 +++++++-
 .../samples/attribute-dynamic-no-dependencies/_config.js  | 5 +++++
 .../samples/attribute-dynamic-no-dependencies/main.html   | 1 +
 3 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 test/runtime/samples/attribute-dynamic-no-dependencies/_config.js
 create mode 100644 test/runtime/samples/attribute-dynamic-no-dependencies/main.html

diff --git a/src/compile/nodes/Element.ts b/src/compile/nodes/Element.ts
index a2a6f8d5b4dd..403b9cce8bee 100644
--- a/src/compile/nodes/Element.ts
+++ b/src/compile/nodes/Element.ts
@@ -152,8 +152,14 @@ export default class Element extends Node {
 		);
 
 		this.attributes.forEach(attr => {
-			if (attr.dependencies.size) {
+			if (
+				attr.chunks &&
+				attr.chunks.length &&
+				(attr.chunks.length > 1 || attr.chunks[0].type !== 'Text')
+			) {
 				this.parent.cannotUseInnerHTML();
+			}
+			if (attr.dependencies.size) {
 				block.addDependencies(attr.dependencies);
 
 				// special case — <option value={foo}> — see below
diff --git a/test/runtime/samples/attribute-dynamic-no-dependencies/_config.js b/test/runtime/samples/attribute-dynamic-no-dependencies/_config.js
new file mode 100644
index 000000000000..acf3c64bdd90
--- /dev/null
+++ b/test/runtime/samples/attribute-dynamic-no-dependencies/_config.js
@@ -0,0 +1,5 @@
+export default {
+	html: `
+		<div><div title='foo'>bar</div></div>
+	`,
+};
diff --git a/test/runtime/samples/attribute-dynamic-no-dependencies/main.html b/test/runtime/samples/attribute-dynamic-no-dependencies/main.html
new file mode 100644
index 000000000000..5d90c0ea58ad
--- /dev/null
+++ b/test/runtime/samples/attribute-dynamic-no-dependencies/main.html
@@ -0,0 +1 @@
+<div><div title={'foo'}>bar</div></div>