Skip to content

subscribe to global stores from script #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019
Merged

subscribe to global stores from script #2314

merged 1 commit into from
Mar 25, 2019

Conversation

Conduitry
Copy link
Member

Fixes #2139 hopefully for real. The previous fix only addressed references to global stores from the template, not the script.

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #2314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2314   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1536b2...f063964. Read the comment docs.

@Conduitry Conduitry changed the title subscribe to globals stores from script subscribe to global stores from script Mar 25, 2019
@Rich-Harris Rich-Harris merged commit 415da7d into master Mar 25, 2019
@Rich-Harris Rich-Harris deleted the gh-2139-script branch March 25, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set property 'subscribable' of undefined
3 participants