From aff737a102337ee4e9efa130b964ceec455eca66 Mon Sep 17 00:00:00 2001 From: Nisar Hassan Naqvi Date: Fri, 20 Mar 2020 11:11:09 +0000 Subject: [PATCH] simplifies code contributions by fully automating the dev setup with gitpod. --- .gitpod.Dockerfile | 7 +++++++ .gitpod.yml | 20 ++++++++++++++++++++ CHANGELOG.md | 4 ++++ CONTRIBUTING.md | 10 ++++++++++ README.md | 14 ++++++++++++++ 5 files changed, 55 insertions(+) create mode 100644 .gitpod.Dockerfile create mode 100644 .gitpod.yml diff --git a/.gitpod.Dockerfile b/.gitpod.Dockerfile new file mode 100644 index 000000000000..503638097000 --- /dev/null +++ b/.gitpod.Dockerfile @@ -0,0 +1,7 @@ +FROM gitpod/workspace-full + +USER gitpod + +RUN sudo apt-get update && \ + sudo apt-get install -yq chromium-browser && \ + sudo rm -rf /var/lib/apt/lists/* diff --git a/.gitpod.yml b/.gitpod.yml new file mode 100644 index 000000000000..5901fcc49e18 --- /dev/null +++ b/.gitpod.yml @@ -0,0 +1,20 @@ +image: + file: .gitpod.Dockerfile +tasks: + - init: > + cd site && + npm install && + sed -ri "s/http:\/\/\\\$\\{window\.location\.hostname\\}:\\\$\\{port\\}\/__sapper__/$(gp url 10000 | sed "s_/_\\\\/_g")\/__sapper__/" ./node_modules/sapper/sapper-dev-client.js && + npm run update + command: npm run dev + - init: npm install + command: npm run dev +ports: + - port: 3000 + onOpen: open-preview + - port: 10000 + onOpen: ignore + +vscode: + extensions: + - JamesBirtles.svelte-vscode@0.4.0:aicIqbjKmEBw3n8OhIUmwA== \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ace7d81049f..93a8262121ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Svelte changelog +## 3.20.1 + +* Fix compiler regression with slots ([#4562](https://github.com/sveltejs/svelte/issues/4562)) + ## 3.20.0 * Allow destructuring in `{#await}` blocks ([#1851](https://github.com/sveltejs/svelte/issues/1851)) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f7df9770dbcf..5f58ab63c25f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -49,6 +49,16 @@ When [opening a new issue](https://github.com/sveltejs/svelte/issues/new/choose) 1. After cloning the repository, run `npm install` in the root of the repository. 1. To start a development server, run `npm run dev`. +## Online one-click setup for contributing + +You can use Gitpod (a free online VS Code like-IDE) for contributing. With a single click it will launch a workspace and automatically: + +- clone the svelte repo. +- install the dependencies. +- run `npm run dev` in `/` and `/site`. + +[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/sveltejs/svelte) + ## Pull requests diff --git a/README.md b/README.md index fa725804a984..80f707fadad3 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,10 @@ Cybernetically enhanced web apps: Svelte + + Gitpod Ready-to-Code + + npm version @@ -51,6 +55,16 @@ To watch for changes and continually rebuild the package (this is useful if you' npm run dev ``` +### Online setup with one-click + +You can use Gitpod (a free online VS Code like-IDE) for the online setup. With a single click it will launch a workspace and automatically: + +- clone the svelte repo. +- install the dependencies. +- run `npm run dev` in `/` and `/site`. + +[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/sveltejs/svelte) + The compiler is written in [TypeScript](https://www.typescriptlang.org/), but don't let that put you off — it's basically just JavaScript with type annotations. You'll pick it up in no time. If you're using an editor other than [Visual Studio Code](https://code.visualstudio.com/) you may need to install a plugin in order to get syntax highlighting and code hints etc.