Skip to content

node.js generator can create invalid package.json files #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fehguy opened this issue Feb 9, 2016 · 1 comment
Open

node.js generator can create invalid package.json files #2088

fehguy opened this issue Feb 9, 2016 · 1 comment
Labels
Enhancement: General help wanted Server: Nodejs
Milestone
Future

Comments

@fehguy
Copy link
Contributor

fehguy commented Feb 9, 2016

We need to properly escape the name, and version as well.

For instance:

name: "it's bad",
version: "1"

Will give an error on the name and the version as well.

Reported by @Kesh92
@fehguy fehguy added this to the v2.1.6 milestone Feb 9, 2016
@wing328 wing328 modified the milestones: v2.2.0, v2.1.6 Mar 19, 2016
@wing328 wing328 modified the milestones: v2.3.0, v2.2.0 Jul 8, 2016
@wing328 wing328 modified the milestones: v2.2.1, v2.2.2 Aug 8, 2016
@wing328 wing328 modified the milestones: Future, v2.2.2 Feb 15, 2017
@wing328
Copy link
Contributor

wing328 commented Feb 15, 2017

UPDATE: #4648 escapes the name properly

version still needs to be escaped properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement: General help wanted Server: Nodejs
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@fehguy @wing328