Skip to content

AddFile to the Rest Call #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lakeba opened this issue May 29, 2015 · 8 comments
Closed

AddFile to the Rest Call #811

lakeba opened this issue May 29, 2015 · 8 comments

Comments

@lakeba
Copy link

lakeba commented May 29, 2015

Can we have the upload/download function to a rest call or at least upload/download of a stream?

@wing328
Copy link
Contributor

wing328 commented May 30, 2015

It's not supported at the moment. Please have a look at #733

@lakeba
Copy link
Author

lakeba commented May 30, 2015

I think that just exposing the HttpClient (RestClient in case of C#) will be enough as this class support the add file and the Download.

@wing328
Copy link
Contributor

wing328 commented May 30, 2015

You may want to refer to the PR #808 about making API Client pluggable as the change will allow the RestClient (in ApiClient class) to be configurable

@lakeba
Copy link
Author

lakeba commented May 30, 2015

you are brilliant !! I hope only that your changes will be merged soon in the main project!
I hope you can do the same for Android and ObjectiveC

@wing328
Copy link
Contributor

wing328 commented May 30, 2015

FYI. Some other clients (e.g. PHP) have gone through similar change already, e.g. #778

@lakeba
Copy link
Author

lakeba commented May 30, 2015

why you don't do the changes in your fork ? android, ios and csharp would cover the most important!

@wing328
Copy link
Contributor

wing328 commented Jun 10, 2015

@uniprof #808 has been merged. Did you have a chance to test ? Can this be closed ?

@lakeba
Copy link
Author

lakeba commented Jun 10, 2015

Work perfectly!

@lakeba lakeba closed this as completed Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants