fixing get by numeric key

Author: vearutop

src/Cli/Diff.php

@@ -29,7 +29,7 @@ class Diff extends Command
     static function setUpDefinition(Definition $definition, $options)
     {
         $definition->name = 'json-diff';
-        $definition->version = 'v1.1.0';
+        $definition->version = 'v1.1.1';
         $definition->description = 'JSON diff and rearrange tool for PHP, https://github.com/swaggest/json-diff';
 
         $options->action = Command\Option::create()->setIsUnnamed()->setIsRequired()

src/JsonProcessor.php

@@ -37,18 +37,19 @@ public static function getByPath(&$holder, $path)
         if ('#' === $pathItems[0]) {
             array_shift($pathItems);
         }
-        $ref = &$holder;
+        $ref = $holder;
         while (null !== $key = array_shift($pathItems)) {
             $key = urldecode($key);
             if ($ref instanceof \stdClass) {
-                if (property_exists($ref, $key)) {
-                    $ref = &$ref->$key;
+                $vars = get_object_vars($ref);
+                if (array_key_exists($key, $vars)) {
+                    $ref = $vars[$key];
                 } else {
                     throw new Exception('Key not found: ' . $key);
                 }
             } else {
                 if (array_key_exists($key, $ref)) {
-                    $ref = &$ref[$key];
+                    $ref = $ref[$key];
                 } else {
                     throw new Exception('Key not found: ' . $key);
                 }

tests/src/ProcessorTest.php

@@ -29,5 +29,7 @@ public function testProcess()
         JsonProcessor::pushByPath($json, '#/l1/l2/1/1', 1);
 
         $this->assertSame('{"l1":{"l2":[[0],{"1":1}]}}', json_encode($json));
+
+        $this->assertSame(1, JsonProcessor::getByPath($json, '#/l1/l2/1/1'));
     }
 }