KafkaConsumer: store offsets when .finishing

felixschlegel · felixschlegel · commit 13eb697b6d24 · 2023-08-23T11:10:57.000+01:00
Motivation: This PR addresses issue #119. The `KafkaConsumer` should not `fatalError` when storing offsets in state `.finishing`. See #119 (comment) for more information why.
diff --git a/Sources/Kafka/KafkaConsumer.swift b/Sources/Kafka/KafkaConsumer.swift
@@ -585,7 +585,9 @@ extension KafkaConsumer {
                 fatalError("Cannot store offset when consumption has been stopped")
             case .consuming(let client, _):
                 return .storeOffset(client: client)
-            case .finishing, .finished:
+            case .finishing(let client):
+                return .storeOffset(client: client)
+            case .finished:
                 fatalError("\(#function) invoked while still in state \(self.state)")
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -585,7 +585,9 @@ extension KafkaConsumer {`
`585`	`585`	`fatalError("Cannot store offset when consumption has been stopped")`
`586`	`586`	`case .consuming(let client, _):`
`587`	`587`	`return .storeOffset(client: client)`
`588`		`- case .finishing, .finished:`
	`588`	`+ case .finishing(let client):`
	`589`	`+ return .storeOffset(client: client)`
	`590`	`+ case .finished:`
`589`	`591`	`fatalError("\(#function) invoked while still in state \(self.state)")`
`590`	`592`	`}`
`591`	`593`	`}`