[lldb/Host] Pass a StringRef to the FileSpec ctor

JDevlieghere · JDevlieghere · commit 6e693386afed · 2020-04-28T19:21:58.000-07:00
The FileSpec constructor takes a StringRef so there's no point in going
through a C string.
diff --git a/lldb/source/Host/common/Host.cpp b/lldb/source/Host/common/Host.cpp
@@ -521,7 +521,7 @@ Status Host::RunShellCommand(const Args &args, const FileSpec &working_dir,
     }
   }
 
-  FileSpec output_file_spec(output_file_path.c_str());
+  FileSpec output_file_spec(output_file_path.str());
   // Set up file descriptors.
   launch_info.AppendSuppressFileAction(STDIN_FILENO, true, false);
   if (output_file_spec)

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ Status Host::RunShellCommand(const Args &args, const FileSpec &working_dir,`
`521`	`521`	`}`
`522`	`522`	`}`
`523`	`523`
`524`		`- FileSpec output_file_spec(output_file_path.c_str());`
	`524`	`+ FileSpec output_file_spec(output_file_path.str());`
`525`	`525`	`// Set up file descriptors.`
`526`	`526`	`launch_info.AppendSuppressFileAction(STDIN_FILENO, true, false);`
`527`	`527`	`if (output_file_spec)`