[llvm-readobj][ELF] Name offsets can be zero.

hyp · hyp · commit 9aa6c1320afd · 2019-10-27T16:42:38.000-07:00
Original fix by Michael Spencer.
diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -1648,7 +1648,7 @@ template <typename ELFT> void ELFDumper<ELFT>::parseDynamicTable() {
   }
   if (StringTableBegin)
     DynamicStringTable = StringRef(StringTableBegin, StringTableSize);
-  if (SONameOffset && SONameOffset < DynamicStringTable.size())
+  if (SONameOffset < DynamicStringTable.size())
     SOName = DynamicStringTable.data() + SONameOffset;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1648,7 +1648,7 @@ template <typename ELFT> void ELFDumper<ELFT>::parseDynamicTable() {`
`1648`	`1648`	`}`
`1649`	`1649`	`if (StringTableBegin)`
`1650`	`1650`	`DynamicStringTable = StringRef(StringTableBegin, StringTableSize);`
`1651`		`- if (SONameOffset && SONameOffset < DynamicStringTable.size())`
	`1651`	`+ if (SONameOffset < DynamicStringTable.size())`
`1652`	`1652`	`SOName = DynamicStringTable.data() + SONameOffset;`
`1653`	`1653`	`}`
`1654`	`1654`