[DAGCombiner] Add node to the worklist in topological order after relegalization.

deadalnix · deadalnix · commit a1e5ef3fd424 · 2019-08-27T11:06:09.000Z
Summary: As per title. Reviewers: craig.topper, efriedma, RKSimon, lebedev.ri Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66702 llvm-svn: 370040
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -1664,8 +1664,8 @@ void DAGCombiner::Run(CombineLevel AtLevel) {
       bool NIsValid = DAG.LegalizeOp(N, UpdatedNodes);
 
       for (SDNode *LN : UpdatedNodes) {
-        AddToWorklist(LN);
         AddUsersToWorklist(LN);
+        AddToWorklist(LN);
       }
       if (!NIsValid)
         continue;

Original file line number	Diff line number	Diff line change
`@@ -1664,8 +1664,8 @@ void DAGCombiner::Run(CombineLevel AtLevel) {`
`1664`	`1664`	`bool NIsValid = DAG.LegalizeOp(N, UpdatedNodes);`
`1665`	`1665`
`1666`	`1666`	`for (SDNode *LN : UpdatedNodes) {`
`1667`		`- AddToWorklist(LN);`
`1668`	`1667`	`AddUsersToWorklist(LN);`
	`1668`	`+ AddToWorklist(LN);`
`1669`	`1669`	`}`
`1670`	`1670`	`if (!NIsValid)`
`1671`	`1671`	`continue;`