Use UInt64.random instead of arc4random

Author: ahoppen

Sources/CompletionScoringTestSupport/RepeatableRandomNumberGenerator.swift

@@ -60,8 +60,8 @@ package struct RepeatableRandomNumberGenerator: RandomNumberGenerator {
 
   static func generateSeed() {
     let numbers: [UInt64] = (0..<1024).map { _ in
-      let lo = UInt64(arc4random())
-      let hi = UInt64(arc4random())
+      let lo = UInt64.random(in: 0...UInt64.max)
+      let hi = UInt64.random(in: 0...UInt64.max)
       return (hi << 32) | lo
     }
     let header =

Sources/CompletionScoringTestSupport/TestExtensions.swift

@@ -47,7 +47,7 @@ extension XCTestCase {
     while elapsed < 1.0 {
       elapsed += duration {
         let integers = Array(count: integers) {
-          arc4random()
+          UInt64.random(in: 0...UInt64.max)
         }
         DispatchQueue.concurrentPerform(iterations: 128) { _ in
           integers.withUnsafeBytes { bytes in