LSP exports too many symbols

[compnerd]

When building LSP with SPM we hit the export symbol limits:

lld-link: error: too many exported symbols (max 65535)  
clang: error: linker command failed with exit code 1 (use -v to see invocation)                                        
[1/14] Linking S:\SourceCache\Sourcekit-LSP\.build\x86_64-unknown-windows-msvc\debug\_SourceKitLSP.dll

[ahoppen]

rdar://103582935

[ahoppen]

@compnerd Is this still an issue?

[compnerd]

@ahoppen I can double check, but I expect it to be so. This is caused by the use of swift-syntax. The underlying issue is SPM. It does not have the concept of libraries, and the code is built incorrect. The result of that is that we try to export all public symbols in swift-syntax, which exceeds the 65535 symbol limit. We can build with CMake, but this is a problem that we need to resolve.

[MaxDesiatov]

The underlying issue is SPM. It does not have the concept of libraries, and the code is built incorrect. The result of that is that we try to export all public symbols in swift-syntax, which exceeds the 65535 symbol limit. We can build with CMake, but this is a problem that we need to resolve.

Do we have a corresponding issue on the SwiftPM repository to track this?

[compnerd]

@MaxDesiatov 😧 making me do the work that I was trying to avoid! 😆

swiftlang/swift-package-manager#5597 is the issue (I just was being lazy and trying to not dig it up).

[krzyzanowskim]

ref #982

[ahoppen]

I have worked around this by building swift-syntax as a dynamic library (SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY environment variable). Closing since there are no more actionable steps in SourceKit-LSP here.