Fix custom doc link title issue

Kyle-Ye · Kyle-Ye · commit 31007e586a14 · 2022-10-08T17:53:44.000+08:00
diff --git a/Sources/SwiftDocC/Model/Rendering/RenderContentCompiler.swift b/Sources/SwiftDocC/Model/Rendering/RenderContentCompiler.swift
@@ -163,7 +163,11 @@ struct RenderContentCompiler: MarkupVisitor {
             return [RenderInlineContent.text(link.plainText)]
         }
         
-        return [RenderInlineContent.reference(identifier: .init(resolved.absoluteString), isActive: true, overridingTitle: nil, overridingTitleInlineContent: nil)]
+        let linkTitleInlineContent =  link.children.flatMap { visit($0) } as! [RenderInlineContent]
+        let plainTextLinkTitle = linkTitleInlineContent.plainText
+        let overridingTitle = plainTextLinkTitle == destination ? nil : plainTextLinkTitle
+        // TODO: We should do the same logic for overridingTitleInlineContent later
+        return [RenderInlineContent.reference(identifier: .init(resolved.absoluteString), isActive: true, overridingTitle: overridingTitle, overridingTitleInlineContent: nil)]
     }
     
     mutating func resolveTopicReference(_ destination: String) -> ResolvedTopicReference? {

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,11 @@ struct RenderContentCompiler: MarkupVisitor {`
`163`	`163`	`return [RenderInlineContent.text(link.plainText)]`
`164`	`164`	`}`
`165`	`165`
`166`		`- return [RenderInlineContent.reference(identifier: .init(resolved.absoluteString), isActive: true, overridingTitle: nil, overridingTitleInlineContent: nil)]`
	`166`	`+ let linkTitleInlineContent = link.children.flatMap { visit($0) } as! [RenderInlineContent]`
	`167`	`+ let plainTextLinkTitle = linkTitleInlineContent.plainText`
	`168`	`+ let overridingTitle = plainTextLinkTitle == destination ? nil : plainTextLinkTitle`
	`169`	`+ // TODO: We should do the same logic for overridingTitleInlineContent later`
	`170`	`+ return [RenderInlineContent.reference(identifier: .init(resolved.absoluteString), isActive: true, overridingTitle: overridingTitle, overridingTitleInlineContent: nil)]`
`167`	`171`	`}`
`168`	`172`
`169`	`173`	`mutating func resolveTopicReference(_ destination: String) -> ResolvedTopicReference? {`