Remove last trace of TSCUtility

Replace use of `Diagnostic.fatalError` with a
`SwiftDriver.Diagnostics.errorsEmitted` type which removes the final
reference to `TSCUtility` in the actual shipping code.  References
within the test suite may remain for now.

Author: compnerd

Sources/SwiftDriver/Driver/Driver.swift

@@ -26,10 +26,23 @@ import struct TSCBasic.RelativePath
 import var TSCBasic.localFileSystem
 import var TSCBasic.stderrStream
 import var TSCBasic.stdoutStream
-import enum TSCUtility.Diagnostics
 
 /// The Swift driver.
 public struct Driver {
+  /// Stub Error for terminating the process.
+  public enum Diagnostics: DiagnosticData {
+    case errorsEmitted
+  }
+
+  extension Diagnostics {
+    public var description: String {
+      switch self {
+      case .errorsEmitted:
+        return "errors were encountered"
+      }
+    }
+  }
+
   public enum Error: Swift.Error, Equatable, DiagnosticData {
     case unknownOrMissingSubcommand(String)
     case invalidDriverName(String)
@@ -1839,7 +1852,7 @@ extension Driver {
         if let originalPath = swiftFiles[basename] {
           diagnosticsEngine.emit(.error_two_files_same_name(basename: basename, firstPath: originalPath, secondPath: input))
           diagnosticsEngine.emit(.note_explain_two_files_same_name)
-          throw Diagnostics.fatalError
+          throw Diagnostics.errorsEmitted
         } else {
           swiftFiles[basename] = input
         }
@@ -1852,7 +1865,7 @@ extension Driver {
       if let mainPath = swiftFiles["main.swift"] {
         diagnosticsEngine.emit(.error_two_files_same_name(basename: "main.swift", firstPath: mainPath, secondPath: "-e"))
         diagnosticsEngine.emit(.note_explain_two_files_same_name)
-        throw Diagnostics.fatalError
+        throw Diagnostics.errorsEmitted
       }
 
       try withTemporaryDirectory(dir: fileSystem.tempDirectory, removeTreeOnDeinit: false) { absPath in
@@ -2878,7 +2891,7 @@ extension Triple {
       return WindowsToolchain.self
     default:
       diagnosticsEngine.emit(.error_unknown_target(triple))
-      throw Diagnostics.fatalError
+      throw Diagnostics.errorsEmitted
     }
   }
 }

Sources/SwiftDriver/Jobs/FrontendJobHelpers.swift

@@ -14,7 +14,6 @@ import class TSCBasic.LocalFileOutputByteStream
 import class TSCBasic.TerminalController
 import struct TSCBasic.RelativePath
 import var TSCBasic.stderrStream
-import enum TSCUtility.Diagnostics
 
 /// Whether we should produce color diagnostics by default.
 fileprivate func shouldColorDiagnostics() -> Bool {
@@ -474,7 +473,7 @@ extension Driver {
     if parsedOptions.hasArgument(.updateCode) {
       guard compilerMode == .standardCompile else {
         diagnosticEngine.emit(.error_update_code_not_supported(in: compilerMode))
-        throw Diagnostics.fatalError
+        throw Diagnostics.errorsEmitted
       }
       assert(primaryInputs.count == 1, "Standard compile job had more than one primary input")
       let input = primaryInputs[0]

Sources/SwiftDriverExecution/MultiJobExecutor.swift

@@ -26,7 +26,6 @@ import protocol TSCBasic.DiagnosticData
 import protocol TSCBasic.FileSystem
 import struct TSCBasic.Diagnostic
 import struct TSCBasic.ProcessResult
-import enum TSCUtility.Diagnostics
 
 // We either import the llbuildSwift shared library or the llbuild framework.
 #if canImport(llbuildSwift)
@@ -318,7 +317,7 @@ public final class MultiJobExecutor {
 
     // Throw the stub error the build didn't finish successfully.
     if !result.success {
-      throw Diagnostics.fatalError
+      throw Diagnostics.errorsEmitted
     }
   }
 

Sources/swift-driver/main.swift

@@ -32,7 +32,6 @@ import class TSCBasic.Process
 import class TSCBasic.ProcessSet
 import protocol TSCBasic.DiagnosticData
 import var TSCBasic.localFileSystem
-import enum TSCUtility.Diagnostics
 
 let interruptSignalSource = DispatchSource.makeSignalSource(signal: SIGINT)
 let diagnosticsEngine = DiagnosticsEngine(handlers: [Driver.stderrDiagnosticsHandler])
@@ -100,20 +99,23 @@ do {
 
   // FIXME: The following check should be at the end of Driver.init, but current
   // usage of the DiagnosticVerifier in tests makes this difficult.
-  guard !driver.diagnosticEngine.hasErrors else { throw Diagnostics.fatalError }
+  guard !driver.diagnosticEngine.hasErrors else {
+    exit(getExitCode(EXIT_FAILURE))
+  }
 
   let jobs = try driver.planBuild()
   try driver.run(jobs: jobs)
 
   if driver.diagnosticEngine.hasErrors {
     exit(getExitCode(EXIT_FAILURE))
   }
+
   exit(getExitCode(0))
-} catch Diagnostics.fatalError {
-  exit(getExitCode(EXIT_FAILURE))
 } catch let diagnosticData as DiagnosticData {
   diagnosticsEngine.emit(.error(diagnosticData))
   exit(getExitCode(EXIT_FAILURE))
+} catch Diagnostics.errorsEmitted {
+  exit(getExitCode(EXIT_FAILURE))
 } catch {
   print("error: \(error)")
   exit(getExitCode(EXIT_FAILURE))