From a52059d22b0f9ad0d52deeebaf73c9b6434578ee Mon Sep 17 00:00:00 2001
From: Saleem Abdulrasool <compnerd@compnerd.org>
Date: Wed, 24 May 2023 08:33:58 -0700
Subject: [PATCH] WiX: remove unnecessary MSI Property

The ability to distribute the debug information with the installer has
been removed as the total size of the debug information vastly outsizes
the packaging of the toolchain (~7x).  The traditional way to distribute
debug information on Windows is via a symbol server with indexing via
SaaS such as Azure Packages.  Remove the now defunct property setting.
---
 platforms/Windows/installer-amd64.wxs | 8 ++------
 platforms/Windows/installer-arm64.wxs | 8 ++------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/platforms/Windows/installer-amd64.wxs b/platforms/Windows/installer-amd64.wxs
index 6dc646c2..16c28347 100644
--- a/platforms/Windows/installer-amd64.wxs
+++ b/platforms/Windows/installer-amd64.wxs
@@ -7,17 +7,13 @@
     <Chain>
       <?if $(var.RequiredChain) != "" ?>
       <?foreach MSI in $(var.RequiredChain) ?>
-      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes">
-        <MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
-      </MsiPackage>
+      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" />
       <?endforeach?>
       <?endif?>
 
       <?if $(var.OptionalChain) != "" ?>
       <?foreach MSI in $(var.OptionalChain) ?>
-      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes">
-        <MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
-      </MsiPackage>
+      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes" />
       <?endforeach?>
       <?endif?>
     </Chain>
diff --git a/platforms/Windows/installer-arm64.wxs b/platforms/Windows/installer-arm64.wxs
index b76b291d..03c7f508 100644
--- a/platforms/Windows/installer-arm64.wxs
+++ b/platforms/Windows/installer-arm64.wxs
@@ -7,17 +7,13 @@
     <Chain>
       <?if $(var.RequiredChain) != "" ?>
       <?foreach MSI in $(var.RequiredChain) ?>
-      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes">
-        <MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
-      </MsiPackage>
+      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" />
       <?endforeach?>
       <?endif?>
 
       <?if $(var.OptionalChain) != "" ?>
       <?foreach MSI in $(var.OptionalChain) ?>
-      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes">
-        <MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
-      </MsiPackage>
+      <MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes" />
       <?endforeach?>
       <?endif?>
     </Chain>