From 1df2009d94c0ce02cc0a87f9526334f4c9d34592 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Sat, 27 May 2023 12:16:57 -0700 Subject: [PATCH] WiX: simplify the runtime package definition - Use durable GUID generation for auto-generation of the GUID. - Combine the platform definitions into a singular source to avoid drift. This avoids having to keep the variants in sync and provides an easier upgrade path. This is the first step towards enabling a non-admin experience for users. --- platforms/Windows/devtools.wixproj | 2 +- platforms/Windows/runtime-amd64.wxs | 116 ------------------------- platforms/Windows/runtime-arm64.wxs | 116 ------------------------- platforms/Windows/runtime-x86.wxs | 115 ------------------------- platforms/Windows/runtime.wixproj | 4 +- platforms/Windows/runtime.wxs | 128 ++++++++++++++++++++++++++++ platforms/Windows/toolchain.wixproj | 2 +- platforms/Windows/version.wxi | 10 +++ 8 files changed, 142 insertions(+), 351 deletions(-) delete mode 100644 platforms/Windows/runtime-amd64.wxs delete mode 100644 platforms/Windows/runtime-arm64.wxs delete mode 100644 platforms/Windows/runtime-x86.wxs create mode 100644 platforms/Windows/runtime.wxs diff --git a/platforms/Windows/devtools.wixproj b/platforms/Windows/devtools.wixproj index ae3f5d6a..de04e2ae 100644 --- a/platforms/Windows/devtools.wixproj +++ b/platforms/Windows/devtools.wixproj @@ -19,7 +19,7 @@ - ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT); + ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT); false true true diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs deleted file mode 100644 index 80d88b42..00000000 --- a/platforms/Windows/runtime-amd64.wxs +++ /dev/null @@ -1,116 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs deleted file mode 100644 index 0868ac47..00000000 --- a/platforms/Windows/runtime-arm64.wxs +++ /dev/null @@ -1,116 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs deleted file mode 100644 index b289c29f..00000000 --- a/platforms/Windows/runtime-x86.wxs +++ /dev/null @@ -1,115 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/runtime.wixproj b/platforms/Windows/runtime.wixproj index b6281d90..3ce2494e 100644 --- a/platforms/Windows/runtime.wixproj +++ b/platforms/Windows/runtime.wixproj @@ -19,7 +19,7 @@ - ProductVersion=$(ProductVersion);SDK_ROOT=$(SDK_ROOT) + ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);SDK_ROOT=$(SDK_ROOT) @@ -42,6 +42,6 @@ - + diff --git a/platforms/Windows/runtime.wxs b/platforms/Windows/runtime.wxs new file mode 100644 index 00000000..ea4011e0 --- /dev/null +++ b/platforms/Windows/runtime.wxs @@ -0,0 +1,128 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/platforms/Windows/toolchain.wixproj b/platforms/Windows/toolchain.wixproj index 89a8f692..744ec0a7 100644 --- a/platforms/Windows/toolchain.wixproj +++ b/platforms/Windows/toolchain.wixproj @@ -19,7 +19,7 @@ - ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);TOOLCHAIN_ROOT_USR_LIB_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\clang + ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);TOOLCHAIN_ROOT_USR_LIB_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\clang false true true diff --git a/platforms/Windows/version.wxi b/platforms/Windows/version.wxi index c16f26bc..3065d0fc 100644 --- a/platforms/Windows/version.wxi +++ b/platforms/Windows/version.wxi @@ -8,4 +8,14 @@ + + + + + + + + + +