diff --git a/platforms/Windows/bld/bld.wixproj b/platforms/Windows/bld/bld.wixproj
index bbebd1a2..d75069e2 100644
--- a/platforms/Windows/bld/bld.wixproj
+++ b/platforms/Windows/bld/bld.wixproj
@@ -2,7 +2,6 @@
$(DefineConstants);
- DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);
TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);
TOOLCHAIN_ROOT_USR_LIB_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\clang;
TOOLCHAIN_ROOT_USR_LIB_SWIFT_CLANG=$(TOOLCHAIN_ROOT)\usr\lib\swift\clang;
diff --git a/platforms/Windows/bld/bld.wxs b/platforms/Windows/bld/bld.wxs
index 294a8df5..127b6738 100644
--- a/platforms/Windows/bld/bld.wxs
+++ b/platforms/Windows/bld/bld.wxs
@@ -352,40 +352,40 @@
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
diff --git a/platforms/Windows/bundle/installer.wixproj b/platforms/Windows/bundle/installer.wixproj
index 4ab56054..70f8d952 100644
--- a/platforms/Windows/bundle/installer.wixproj
+++ b/platforms/Windows/bundle/installer.wixproj
@@ -6,12 +6,13 @@
https://aka.ms/vs/$(VSMajorVersion)/release/vc_redist.$(ProductArchitecture).exe
$(DefineConstants);
- INCLUDE_X86_SDK=$(INCLUDE_X86_SDK);
- INCLUDE_ARM64_SDK=$(INCLUDE_ARM64_SDK);
- ANDROID_INCLUDE_ARM64_SDK=$(ANDROID_INCLUDE_ARM64_SDK);
- ANDROID_INCLUDE_x86_64_SDK=$(ANDROID_INCLUDE_x86_64_SDK);
- ANDROID_INCLUDE_ARM_SDK=$(ANDROID_INCLUDE_ARM_SDK);
- ANDROID_INCLUDE_X86_SDK=$(ANDROID_INCLUDE_X86_SDK);
+ INCLUDE_ANDROID_ARM_SDK=$(INCLUDE_ANDROID_ARM_SDK);
+ INCLUDE_ANDROID_ARM64_SDK=$(INCLUDE_ANDROID_ARM64_SDK);
+ INCLUDE_ANDROID_X86_SDK=$(INCLUDE_ANDROID_X86_SDK);
+ INCLUDE_ANDROID_X86_64_SDK=$(INCLUDE_ANDROID_X86_64_SDK);
+ INCLUDE_WINDOWS_AMD64_SDK=$(INCLUDE_WINDOWS_AMD64_SDK);
+ INCLUDE_WINDOWS_ARM64_SDK=$(INCLUDE_WINDOWS_ARM64_SDK);
+ INCLUDE_WINDOWS_X86_SDK=$(INCLUDE_WINDOWS_X86_SDK);
@@ -25,30 +26,33 @@
-
-
-
+
+
-
-
+
+
-
-
+
+
-
-
+
+
-
-
+
+
-
-
+
+
+
+
+
+
diff --git a/platforms/Windows/bundle/installer.wxs b/platforms/Windows/bundle/installer.wxs
index 1137736c..7e9d5786 100644
--- a/platforms/Windows/bundle/installer.wxs
+++ b/platforms/Windows/bundle/installer.wxs
@@ -27,22 +27,28 @@
-->
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/platforms/Windows/dbg/dbg.wixproj b/platforms/Windows/dbg/dbg.wixproj
index ed9bd07a..70298d5b 100644
--- a/platforms/Windows/dbg/dbg.wixproj
+++ b/platforms/Windows/dbg/dbg.wixproj
@@ -2,10 +2,7 @@
$(DefineConstants);
- DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);
TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT);
- SWIFT_INSPECT_BUILD=$(SWIFT_INSPECT_BUILD);
- INCLUDE_SWIFT_INSPECT=$(INCLUDE_SWIFT_INSPECT);
diff --git a/platforms/Windows/dbg/dbg.wxs b/platforms/Windows/dbg/dbg.wxs
index 23c18d61..50092278 100644
--- a/platforms/Windows/dbg/dbg.wxs
+++ b/platforms/Windows/dbg/dbg.wxs
@@ -105,14 +105,10 @@
-
-
-
-
-
-
-
-
+
+
+
+
diff --git a/platforms/Windows/ide/ide.wixproj b/platforms/Windows/ide/ide.wixproj
index 1aaf7911..84df0a38 100644
--- a/platforms/Windows/ide/ide.wixproj
+++ b/platforms/Windows/ide/ide.wixproj
@@ -2,7 +2,6 @@
$(DefineConstants);
- DEVTOOLS_ROOT=$(DEVTOOLS_ROOT);
TOOLCHAIN_ROOT=$(TOOLCHAIN_ROOT)
diff --git a/platforms/Windows/ide/ide.wxs b/platforms/Windows/ide/ide.wxs
index 0295ebee..94c952c7 100644
--- a/platforms/Windows/ide/ide.wxs
+++ b/platforms/Windows/ide/ide.wxs
@@ -44,7 +44,7 @@
-
+
diff --git a/platforms/Windows/readme.md b/platforms/Windows/readme.md
index 664206f7..ea69a063 100644
--- a/platforms/Windows/readme.md
+++ b/platforms/Windows/readme.md
@@ -32,14 +32,20 @@ The bundle authoring (in `installer.wxs`) drives optional install directory and
| Variable | Description |
| -------- | ----------- |
| InstallRoot | A formatted string variable that specifies the installation root directory. The default value specified in `installer.wxs` should match the equivalent `INSTALLROOT` authoring in `shared.wxs`. The bundle variable is passed to each `MsiPackage` so overwrites the default directory authored in the MSI packages -- but keeping them in sync avoids the confusion if the default directory should change. |
-| OptionsInstallBld | Controls whether bld.msi will be installed. |
-| OptionsInstallCli | Controls whether cli.msi will be installed. |
-| OptionsInstallDbg | Controls whether dbg.msi will be installed. |
-| OptionsInstallIde | Controls whether ide.msi will be installed. |
-| OptionsInstallRtl | Controls whether rtl.msi will be installed. |
-| OptionsInstallSdkX86 | Controls whether the x86 SDK will be installed. |
-| OptionsInstallSdkAMD64 | Controls whether the AMD64 SDK will be installed. |
-| OptionsInstallSdkArm64 | Controls whether the Arm64 SDK will be installed. |
+| OptionsInstallCLI | Controls whether command-line tools will be installed. |
+| OptionsInstallDBG | Controls whether debugging tools will be installed. |
+| OptionsInstallIDE | Controls whether IDE integration tools will be installed. |
+| OptionsInstallUtilties | Controls whether additional utilities will be installed. |
+| OptionsInstallAndroidSDKAMD64 | Controls whether the Android AMD64 SDK will be installed. |
+| OptionsInstallAndroidSDKARM | Controls whether the Android ARM SDK will be installed. |
+| OptionsInstallAndroidSDKARM64 | Controls whether the Android ARM64 SDK will be installed. |
+| OptionsInstallAndroidSDKX86 | Controls whether the Android X86 SDK will be installed. |
+| OptionsInstallWindowsSDKX86 | Controls whether the Windows X86 SDK will be installed. |
+| OptionsInstallWindowsRedistAMD64 | Controls whether the Windows AMD64 Redistributable MSM will be installed. |
+| OptionsInstallWindowsSDKAMD64 | Controls whether the Windows AMD64 SDK will be installed. |
+| OptionsInstallWindowsRedistARM64 | Controls whether the Windows ARM64 Redistributable MSM will be installed. |
+| OptionsInstallWindowsSDKX86 | Controls whether the Windows X86 SDK will be installed. |
+| OptionsInstallWindowsRedistX86 | Controls whether the Windows X86 Redistributable MSM will be installed. |
Those variables are tied to controls in the bundle theme (`installer\theme.xml`) on the Options page. For example, the install directory is an `Editbox` control that takes the `InstallRoot` name to tie itself to the `InstallRoot` variable in `installer.wxs`:
@@ -50,7 +56,7 @@ Those variables are tied to controls in the bundle theme (`installer\theme.xml`)
Likewise, the feature selection controls are all checkboxes tied to the variables that control feature selection:
```xml
-#(loc.OptionsInstallIde)
+#(loc.OptionsInstallIDE)
```
`Checkbox` controls set variables to `1` when checked and `0` when unchecked.
@@ -60,7 +66,7 @@ The variables are used in `installer.wxs` bundle authoring to control the instal
```xml
@@ -81,7 +87,7 @@ The same variables that drive install directory and feature selection are availa
```sh
-installer.exe /passive InstallRoot=X:\Swift OptionsInstallIde=0 OptionsInstallSdkX86=0 OptionsInstallSdkArm64=0
+installer.exe /passive InstallRoot=X:\Swift OptionsInstallIDE=0 OptionsInstallWindowsSDKX86=0 OptionsInstallWindowsSDKARM64=0
```
To create a layout from a online bundle to allow for offline install:
@@ -106,8 +112,8 @@ MSBuild automatically imports Directory.Build.props files in your tree. We use D
| ArePackageCabsEmbedded | Always set to false to keep the .cab files external to the .msi files. This save user disk space: Burn caches packages so it can always uninstall and repair. MSI also caches packages for uninstall. If the cab is embedded, you have two copies and MSI doesn't always use its cached copy as a source for repair. With an external .cab, MSI caches only the tiny .msi file and not the (relatively huge) .cab. |
| BundleFlavor, IsBundleCompressed | BundleFlavor defaults to `online` to build an online bundle. Set by the invocation of MSBuild to build an online or offline bundle. Controls IsBundleCompressed. |
| DefineConstants | Passes a subset of MSBuild properties into the WiX build as preprocessor variables. |
-| INCLUDE_SWIFT_INSPECT | swift-inspect is currently conditionalized out. Set it to `true` to include it. The property `SWIFT_INSPECT_BUILD` defines the directory to find the artifacts. |
-| INCLUDE_X86_SDK, INCLUDE_ARM64_SDK | The x86 and Arm64 SDKs are currently conditionalized out, pending build changes. Set these to `true` to include them in the bundles. Note that bundle\theme.xml currently has commented-out checkboxes that need to be restored when the x86 and Arm64 SDKs are brought back. |
+| INCLUDE_SWIFT_DOCC | swift-docc is currently conditionalized out. Set it to `true` to include it. The property `SWIFT_DOCC_BUILD` defines the directory to find the artifacts. |
+| INCLUDE_ANDROID_ARM_SDK, INCLUDE_ANDROID_ARM64_SDK, INCLUDE_ANDROID_X86_SDK, INCLUDE_ANDROID_x86_64_SDK, INCLUDE_WINDOWS_AMD64_SDK, INCLUDE_WINDOWS_ARM64_SDK, INCLUDE_WINDOWS_X86_SDK | The included SDKs are currently conditionalized out. Set these to `true` to include them in the bundles. |
## SDKs
@@ -165,7 +171,6 @@ msbuild %SourceRoot%\swift-installer-scripts\platforms\Windows\bundle\installer.
-p:BaseReleaseDownloadUrl=todo://base/release/download/url ^
-p:Configuration=Release ^
-p:BaseOutputPath=%PackageRoot%\online\ ^
- -p:DEVTOOLS_ROOT=%BuildRoot%\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain ^
-p:TOOLCHAIN_ROOT=%BuildRoot%\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain ^
-p:PLATFORM_ROOT_X86=path\to\x86\platform ^
-p:PLATFORM_ROOT_AMD64=path\to\amd64\platform ^
diff --git a/platforms/Windows/android_sdk/android_sdk.wixproj b/platforms/Windows/sdk/drd/sdk.wixproj
similarity index 87%
rename from platforms/Windows/android_sdk/android_sdk.wixproj
rename to platforms/Windows/sdk/drd/sdk.wixproj
index 5d5bd4fc..064f0d69 100644
--- a/platforms/Windows/android_sdk/android_sdk.wixproj
+++ b/platforms/Windows/sdk/drd/sdk.wixproj
@@ -1,6 +1,6 @@
- android_sdk.$(ProductArchitecture)
+ sdk.android.$(ProductArchitecture)
x86
$(SDK_ROOT)\usr\lib\swift\shims
@@ -13,6 +13,7 @@
+
diff --git a/platforms/Windows/android_sdk/android_sdk.wxs b/platforms/Windows/sdk/drd/sdk.wxs
similarity index 99%
rename from platforms/Windows/android_sdk/android_sdk.wxs
rename to platforms/Windows/sdk/drd/sdk.wxs
index 9f1df9c8..ae238b1b 100644
--- a/platforms/Windows/android_sdk/android_sdk.wxs
+++ b/platforms/Windows/sdk/drd/sdk.wxs
@@ -40,7 +40,7 @@
Version="$(NonSemVerProductVersion)"
Scope="$(PackageScope)">
-
+
diff --git a/platforms/Windows/sdk/sdk.wixproj b/platforms/Windows/sdk/win/sdk.wixproj
similarity index 51%
rename from platforms/Windows/sdk/sdk.wixproj
rename to platforms/Windows/sdk/win/sdk.wixproj
index ce51bdae..cd84a9ed 100644
--- a/platforms/Windows/sdk/sdk.wixproj
+++ b/platforms/Windows/sdk/win/sdk.wixproj
@@ -1,6 +1,6 @@
- sdk.$(ProductArchitecture)
+ sdk.windows.$(ProductArchitecture)
x86
$(SDK_ROOT)\usr\lib\swift\shims
@@ -22,18 +22,18 @@
Shared .wixlibs used by other, "normal" packages.
-->
-
-
+
+
-
-
+
+
-
-
+
+
diff --git a/platforms/Windows/sdk/sdk.wxs b/platforms/Windows/sdk/win/sdk.wxs
similarity index 99%
rename from platforms/Windows/sdk/sdk.wxs
rename to platforms/Windows/sdk/win/sdk.wxs
index a408f2d1..eecad8f9 100644
--- a/platforms/Windows/sdk/sdk.wxs
+++ b/platforms/Windows/sdk/win/sdk.wxs
@@ -23,7 +23,7 @@
Version="$(NonSemVerProductVersion)"
Scope="$(PackageScope)">
-
+
diff --git a/platforms/Windows/shared/shared.wxs b/platforms/Windows/shared/shared.wxs
index b983040e..b1dd1330 100644
--- a/platforms/Windows/shared/shared.wxs
+++ b/platforms/Windows/shared/shared.wxs
@@ -59,20 +59,6 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-