load => loadUnaligned

neonichu · neonichu · commit 4c7da4e9fed6 · 2023-09-19T09:56:13.000-07:00
This is the potential source of a crash on x86_64 using the rebranch branch of Swift.

rdar://115675736
diff --git a/Sources/PackagePlugin/Plugin.swift b/Sources/PackagePlugin/Plugin.swift
@@ -303,7 +303,7 @@ internal struct MessageConnection<TX,RX> where TX: Encodable, RX: Decodable {
         }
         
         // Decode the count.
-        let count = header.withUnsafeBytes{ $0.load(as: UInt64.self).littleEndian }
+        let count = header.withUnsafeBytes{ $0.loadUnaligned(as: UInt64.self).littleEndian }
         guard count >= 2 else {
             throw PluginMessageError.invalidPayloadSize
         }

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ internal struct MessageConnection<TX,RX> where TX: Encodable, RX: Decodable {`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`// Decode the count.`
`306`		`- let count = header.withUnsafeBytes{ $0.load(as: UInt64.self).littleEndian }`
	`306`	`+ let count = header.withUnsafeBytes{ $0.loadUnaligned(as: UInt64.self).littleEndian }`
`307`	`307`	`guard count >= 2 else {`
`308`	`308`	`throw PluginMessageError.invalidPayloadSize`
`309`	`309`	`}`