Build targets instead of products from build-script.py

We can’t build library products if they have library type `automatic`. Instead build their targets.

While doing that, I defined a fake target that depends on all targets in the SwiftSyntax package. This way, we can build all targets concurrently, before we were only building `SwiftSyntax` and `SwiftSyntaxBuilder` sequentially. All other targets only got build when running tests.

Author: ahoppen

Package.swift

@@ -274,6 +274,32 @@ let package = Package(
       dependencies: ["SwiftIDEUtils", "SwiftParser", "SwiftSyntax"],
       exclude: ["Inputs"]
     ),
+
+    // MARK: Build target
+    // This is a fake target that depends on all targets in the package.
+    // We need to define it manually because the `SwiftSyntax-Package` target doesn't exist for `swift build`.
+
+    .target(
+      name: "SwiftSyntax-all",
+      dependencies: [
+        "_InstructionCounter",
+        "_SwiftSyntaxTestSupport",
+        "SwiftBasicFormat",
+        "SwiftCompilerPlugin",
+        "SwiftCompilerPluginMessageHandling",
+        "SwiftDiagnostics",
+        "SwiftIDEUtils",
+        "SwiftSyntax",
+        "SwiftSyntaxBuilder",
+        "SwiftSyntaxMacros",
+        "SwiftSyntaxMacrosTestSupport",
+        "SwiftParser",
+        "SwiftParserDiagnostics",
+        "SwiftOperators",
+        "SwiftRefactor",
+        "swift-parser-cli",
+      ]
+    ),
   ]
 )
 

Sources/SwiftSyntax-all/empty.swift

@@ -0,0 +1,2 @@
+// This is a fake target that depends on all targets in the package.
+// We need to define it manually because the `SwiftSyntax-Package` target doesn't exist for `swift build`.

build-script.py

@@ -215,15 +215,19 @@ def __get_swiftpm_invocation(self, package_dir: str) -> List[str]:
 
     def buildProduct(self, product_name: str) -> None:
         print("** Building product " + product_name + " **")
-        self.__build(PACKAGE_DIR, product_name)
+        self.__build(PACKAGE_DIR, product_name, is_product=True)
+
+    def buildTarget(self, target_name: str) -> None:
+        print("** Building target " + target_name + " **")
+        self.__build(PACKAGE_DIR, target_name, is_product=False)
 
     def buildExample(self, example_name: str) -> None:
         print("** Building example " + example_name + " **")
-        self.__build(EXAMPLES_DIR, example_name)
+        self.__build(EXAMPLES_DIR, example_name, is_product=True)
 
-    def __build(self, package_dir: str, product_name: str) -> None:
+    def __build(self, package_dir: str, name: str, is_product: bool) -> None:
         command = list(self.__get_swiftpm_invocation(package_dir))
-        command.extend(["--product", product_name])
+        command.extend(["--product" if is_product else "--target", name])
 
         env = dict(os.environ)
         env["SWIFT_BUILD_SCRIPT_ENVIRONMENT"] = "1"
@@ -499,10 +503,7 @@ def build_command(args: argparse.Namespace) -> None:
             verbose=args.verbose,
             disable_sandbox=args.disable_sandbox,
         )
-        # Until rdar://53881101 is implemented, we cannot request a build of multiple
-        # targets simultaneously. For now, just build one product after the other.
-        builder.buildProduct("SwiftSyntax")
-        builder.buildProduct("SwiftSyntaxBuilder")
+        builder.buildTarget("SwiftSyntax-all")
 
         # Build examples
         builder.buildExample("AddOneToIntegerLiterals")