Skip to content

Represent swift and compiler compilation conditions with separated node #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StevenWong12 opened this issue Jun 10, 2023 · 3 comments
Closed

Represent swift and compiler compilation conditions with separated node #1764

StevenWong12 opened this issue Jun 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@StevenWong12
Copy link
Contributor

Description

#1574 (comment)

Just to remind myself about that.
@StevenWong12 StevenWong12 added the enhancement New feature or request label Jun 10, 2023
@ahoppen
Copy link
Member

ahoppen commented Jun 10, 2023

Tracked in Apple’s issue tracker as rdar://110571334

@ahoppen
Copy link
Member

ahoppen commented Jul 7, 2023

We discussed this last week and actually decided that we don’t want to add special nodes for these directives. The Interpretation of these compilation conditions should be performed in the IfConfig library.

@ahoppen ahoppen closed this as completed Jul 7, 2023
@StevenWong12
Copy link
Contributor Author

StevenWong12 commented Jul 8, 2023 •
edited
Loading

I see. I can help revert the change of adding CanImportExprSyntax and move the corresponding test cases there when the SwiftIfConfig is ready(or recently? I am not quite sure how much this extra node will affect the development of this library)

Btw, should we still keep this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahoppen @StevenWong12