Skip to content

Main branch should have a SwiftSyntax510 module #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephencelis opened this issue Oct 13, 2023 · 4 comments · Fixed by #2283
Closed

Main branch should have a SwiftSyntax510 module #2279

stephencelis opened this issue Oct 13, 2023 · 4 comments · Fixed by #2283
Labels
bug Something isn't working

Comments

@stephencelis
Copy link
Contributor

Description

While it's suggested to use things like #if canImport(SwiftSyntax509) to target specific versions of SwiftSyntax, there's no way to support versions before 509 and after 509 at the moment. A SwiftSyntax510 module should allow libraries to be compatible with the main branch concurrently with 509, though.

Steps to Reproduce

No response

@stephencelis stephencelis added the bug Something isn't working label Oct 13, 2023
@ahoppen
Copy link
Member

ahoppen commented Oct 13, 2023

Tracked in Apple’s issue tracker as rdar://116922161

@Matejkob
Copy link
Contributor

Shouldn't the main branch include both SwiftSyntax510 and SwiftSyntax511, especially since we already have an official release/5.10 branch?

@ahoppen
Copy link
Member

ahoppen commented Oct 13, 2023

Shouldn't the main branch include both SwiftSyntax510 and SwiftSyntax511, especially since we already have an official release/5.10 branch?

Both should contain SwiftSyntax510. I’m not sure about SwiftSyntax511 because we haven’t named the next release yet. Could be Swift 5.11 or Swift 6.0 and I don’t want to add SwiftSyntax511 only to remove it in favor of SwiftSyntax600.

@Matejkob
Copy link
Contributor

I've taken the liberty of preparing PRs for both the main and release/5.10 branches, where I've introduced a new target: SwiftSyntax510.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants