Skip to content

Commit 760cb44

Browse files
committed
remove extra debug statements
1 parent d82de55 commit 760cb44

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

stdlib/public/Concurrency/TaskGroup.cpp

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,9 +1152,8 @@ void AccumulatingTaskGroup::offer(AsyncTask *completedTask, AsyncContext *contex
11521152
// will need to release in the other path.
11531153
lock(); // TODO: remove fragment lock, and use status for synchronization
11541154

1155-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "offer, completedTask:%p (count:%d), status:%s",
1155+
SWIFT_TASK_GROUP_DEBUG_LOG(this, "offer, completedTask:%p, status:%s",
11561156
completedTask,
1157-
swift_retainCount(completedTask),
11581157
statusString().c_str());
11591158

11601159
// Immediately increment ready count and acquire the status
@@ -1251,7 +1250,6 @@ void DiscardingTaskGroup::offer(AsyncTask *completedTask, AsyncContext *context)
12511250
break;
12521251
case ReadyStatus::Error:
12531252
SWIFT_TASK_GROUP_DEBUG_LOG(this, "offer, complete, resume with errorItem.task:%p", readyErrorItem.getTask());
1254-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "offer, complete, expect that it was extra retained %p", readyErrorItem.getTask());
12551253
resumeWaitingTask(readyErrorItem.getTask(), assumed,
12561254
/*hadErrorResult=*/true,
12571255
alreadyDecrementedStatus,
@@ -1374,11 +1372,7 @@ void TaskGroupBase::resumeWaitingTask(
13741372
auto waitingContext =
13751373
static_cast<TaskFutureWaitAsyncContext *>(
13761374
waitingTask->ResumeContext);
1377-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "completed task %p", completedTask);
1378-
1379-
13801375
fillGroupNextResult(waitingContext, result);
1381-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "completed task %p; AFTER FILL", completedTask);
13821376

13831377
// Remove the child from the task group's running tasks list.
13841378
// The parent task isn't currently running (we're about to wake
@@ -1388,16 +1382,10 @@ void TaskGroupBase::resumeWaitingTask(
13881382
// does a parent -> child traversal while recursively holding
13891383
// locks) because we know that the child task is completed and
13901384
// we can't be holding its locks ourselves.
1391-
auto before = completedTask;
13921385
_swift_taskGroup_detachChild(asAbstract(this), completedTask);
1393-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "completedTask %p; AFTER DETACH (count:%d)", completedTask, swift_retainCount(completedTask));
13941386
if (isDiscardingResults() && hadErrorResult && taskWasRetained) {
1395-
SWIFT_TASK_GROUP_DEBUG_LOG(this, "BEFORE RELEASE error task=%p (count:%d)\n",
1396-
completedTask,
1397-
swift_retainCount(completedTask));
13981387
// We only used the task to keep the error in the future fragment around
13991388
// so now that we emitted the error and detached the task, we are free to release the task immediately.
1400-
auto error = completedTask->futureFragment()->getError();
14011389
swift_release(completedTask);
14021390
}
14031391

0 commit comments

Comments
 (0)