Fix SR-15818 and add test

philipturner · philipturner · commit d2f5188cf5b5 · 2022-04-20T21:03:03.000-04:00
diff --git a/include/swift/AST/DiagnosticsSema.def b/include/swift/AST/DiagnosticsSema.def
@@ -3499,8 +3499,8 @@ NOTE(autodiff_attr_original_decl_not_same_type_context,none,
 ERROR(autodiff_attr_original_void_result,none,
       "cannot differentiate void function %0", (DeclName))
 ERROR(autodiff_attr_original_multiple_semantic_results,none,
-      "cannot differentiate functions with both an 'inout' parameter and a "
-      "result", ())
+      "cannot differentiate functions with both a differentiable 'inout' "
+      "parameter and a result", ())
 ERROR(autodiff_attr_result_not_differentiable,none,
       "can only differentiate functions with results that conform to "
       "'Differentiable', but %0 does not conform to 'Differentiable'", (Type))
@@ -5058,8 +5058,8 @@ ERROR(differentiable_function_type_invalid_result,none,
       "function type is '@differentiable%select{|(_linear)}1'",
       (StringRef, bool))
 ERROR(differentiable_function_type_multiple_semantic_results,none,
-      "'@differentiable' function type cannot have both an 'inout' parameter "
-      "and a differentiable result", ())
+      "'@differentiable' function type cannot have both a differentiable "
+      "'inout' parameter and a result", ())
 ERROR(differentiable_function_type_no_differentiability_parameters, 
       none,
       "'@differentiable' function type requires at least one differentiability "
diff --git a/test/AutoDiff/Sema/derivative_attr_type_checking.swift b/test/AutoDiff/Sema/derivative_attr_type_checking.swift
@@ -746,7 +746,7 @@ extension ProtocolRequirementDerivative {
 func multipleSemanticResults(_ x: inout Float) -> Float {
   return x
 }
-// expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+// expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
 @derivative(of: multipleSemanticResults)
 func vjpMultipleSemanticResults(x: inout Float) -> (
   value: Float, pullback: (Float) -> Float
@@ -885,14 +885,14 @@ func vjpNoSemanticResults(_ x: Float) -> (value: Void, pullback: Void) {}
 
 extension InoutParameters {
   func multipleSemanticResults(_ x: inout Float) -> Float { x }
-  // expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+  // expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
   @derivative(of: multipleSemanticResults)
   func vjpMultipleSemanticResults(_ x: inout Float) -> (
     value: Float, pullback: (inout Float) -> Void
   ) { fatalError() }
 
   func inoutVoid(_ x: Float, _ void: inout Void) -> Float {}
-  // expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+  // expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
   @derivative(of: inoutVoid)
   func vjpInoutVoidParameter(_ x: Float, _ void: inout Void) -> (
     value: Float, pullback: (inout Float) -> Void
diff --git a/test/AutoDiff/Sema/differentiable_attr_type_checking.swift b/test/AutoDiff/Sema/differentiable_attr_type_checking.swift
@@ -528,7 +528,7 @@ func two9(x: Float, y: Float) -> Float {
 func inout1(x: Float, y: inout Float) -> Void {
   let _ = x + y
 }
-// expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+// expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
 @differentiable(reverse, wrt: y)
 func inout2(x: Float, y: inout Float) -> Float {
   let _ = x + y
@@ -670,11 +670,11 @@ final class FinalClass: Differentiable {
 @differentiable(reverse, wrt: y)
 func inoutVoid(x: Float, y: inout Float) {}
 
-// expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+// expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
 @differentiable(reverse)
 func multipleSemanticResults(_ x: inout Float) -> Float { x }
 
-// expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+// expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
 @differentiable(reverse, wrt: y)
 func swap(x: inout Float, y: inout Float) {}
 
@@ -687,7 +687,7 @@ extension InoutParameters {
   @differentiable(reverse)
   static func staticMethod(_ lhs: inout Self, rhs: Self) {}
 
-  // expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+  // expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
   @differentiable(reverse)
   static func multipleSemanticResults(_ lhs: inout Self, rhs: Self) -> Self {}
 }
@@ -696,7 +696,7 @@ extension InoutParameters {
   @differentiable(reverse)
   mutating func mutatingMethod(_ other: Self) {}
 
-  // expected-error @+1 {{cannot differentiate functions with both an 'inout' parameter and a result}}
+  // expected-error @+1 {{cannot differentiate functions with both a differentiable 'inout' parameter and a result}}
   @differentiable(reverse)
   mutating func mutatingMethod(_ other: Self) -> Self {}
 }
diff --git a/test/AutoDiff/Sema/differentiable_func_type.swift b/test/AutoDiff/Sema/differentiable_func_type.swift
@@ -40,10 +40,10 @@ let _: @differentiable(_linear) (Float) -> NonDiffType
 
 let _: @differentiable(_linear) (Float) -> Float
 
-// expected-error @+1 {{'@differentiable' function type cannot have both an 'inout' parameter and a differentiable result}}
+// expected-error @+1 {{'@differentiable' function type cannot have both a differentiable 'inout' parameter and a result}}
 let _: @differentiable(reverse) (inout Float) -> Float
 
-// expected-error @+1 {{'@differentiable' function type cannot have both an 'inout' parameter and a differentiable result}}
+// expected-error @+1 {{'@differentiable' function type cannot have both a differentiable 'inout' parameter and a result}}
 let _: @differentiable(_linear) (inout Float) -> Float
 
 // expected-error @+1 {{result type '@differentiable(reverse) (U) -> Float' does not conform to 'Differentiable', but the enclosing function type is '@differentiable'}}
diff --git a/test/AutoDiff/compiler_crashers_fixed/sr15818-inout-noderivative-closure-parameter.swift b/test/AutoDiff/compiler_crashers_fixed/sr15818-inout-noderivative-closure-parameter.swift
@@ -0,0 +1,55 @@
+// RUN: %target-swift-frontend -emit-sil -verify %s
+
+import _Differentiation
+
+// expected-error @+1 {{result type 'Void' does not conform to 'Differentiable', but the enclosing function type is '@differentiable'}}
+typealias MyType = @differentiable(reverse) (inout @noDerivative Float, Float) -> Void
+
+@differentiable(reverse)
+func myFunc(_ x:  inout @noDerivative Float, _ q: Float) -> Void {}
+
+print(myFunc as MyType)
+
+// Original crash:
+// Assertion failed: (Index < Length && "Invalid index!"), function operator[], file ArrayRef.h, line 257.
+// Stack dump:
+// ...
+// 1.  Swift version 5.7-dev (LLVM a9a5fb525c61dd0, Swift f69d528185a8bfe)
+// 2.  Compiling with the current language version
+// 3.  While evaluating request ExecuteSILPipelineRequest(Run pipelines { Mandatory Diagnostic Passes + Enabling Optimization Passes } on SIL for file)
+// 4.  While running pass #46 SILModuleTransform "Differentiation".
+// 5.  While canonicalizing `differentiable_function` SIL node   %12 = differentiable_function [parameters 1] [results 0] %9 : $@callee_guaranteed (@inout Float, Float, Int) -> () // users: %23, %18, %13
+// 6.  While ...in SIL function "@main".
+// Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
+// 0  swift-frontend           0x0000000105719dc0 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
+// 1  swift-frontend           0x0000000105718ef0 llvm::sys::RunSignalHandlers() + 128
+// 2  swift-frontend           0x000000010571a424 SignalHandler(int) + 304
+// 3  libsystem_platform.dylib 0x00000001bb5304e4 _sigtramp + 56
+// 4  libsystem_pthread.dylib  0x00000001bb518eb0 pthread_kill + 288
+// 5  libsystem_c.dylib        0x00000001bb456314 abort + 164
+// 6  libsystem_c.dylib        0x00000001bb45572c err + 0
+// 7  swift-frontend           0x0000000105a1bab8 swift::SILFunctionConventions::getSILArgumentConvention(unsigned int) const (.cold.4) + 0
+// 8  swift-frontend           0x00000001016a1f9c swift::SILFunctionConventions::getSILArgumentConvention(unsigned int) const + 192
+// 9  swift-frontend           0x0000000100ebc888 (anonymous namespace)::OperandOwnershipClassifier::visitFullApply(swift::FullApplySite) + 244
+// 10 swift-frontend           0x0000000100ebae70 swift::Operand::getOperandOwnership() const + 148
+// 11 swift-frontend           0x0000000100ebada0 swift::checkOperandOwnershipInvariants(swift::Operand const*) + 28
+// 12 swift-frontend           0x0000000100fe2cc8 swift::SILInstruction::verifyOperandOwnership() const + 444
+// 13 swift-frontend           0x00000001014f32f4 swift::autodiff::getOrCreateSubsetParametersThunkForLinearMap(swift::SILOptFunctionBuilder&, swift::SILFunction*, swift::CanTypeWrapper<swift::SILFunctionType>, swift::CanTypeWrapper<swift::SILFunctionType>, swift::CanTypeWrapper<swift::SILFunctionType>, swift::AutoDiffDerivativeFunctionKind, swift::AutoDiffConfig const&, swift::AutoDiffConfig const&, swift::autodiff::ADContext&) + 3800
+// 14 swift-frontend           0x00000001014f455c swift::autodiff::getOrCreateSubsetParametersThunkForDerivativeFunction(swift::SILOptFunctionBuilder&, swift::SILValue, swift::SILValue, swift::AutoDiffDerivativeFunctionKind, swift::AutoDiffConfig const&, swift::AutoDiffConfig const&, swift::autodiff::ADContext&) + 2828
+// 15 swift-frontend           0x00000001015f012c (anonymous namespace)::DifferentiationTransformer::promoteToDifferentiableFunction(swift::DifferentiableFunctionInst*, swift::SILBuilder&, swift::SILLocation, swift::autodiff::DifferentiationInvoker) + 7120
+// 16 swift-frontend           0x00000001015ecae0 (anonymous namespace)::DifferentiationTransformer::processDifferentiableFunctionInst(swift::DifferentiableFunctionInst*) + 452
+// 17 swift-frontend           0x00000001015eab14 (anonymous namespace)::Differentiation::run() + 1152
+// 18 swift-frontend           0x0000000101659548 swift::SILPassManager::runModulePass(unsigned int) + 840
+// 19 swift-frontend           0x000000010165eaa4 swift::SILPassManager::execute() + 628
+// 20 swift-frontend           0x0000000101656428 swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 68
+// 21 swift-frontend           0x00000001016563c8 swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 52
+// 22 swift-frontend           0x000000010167c574 swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 28
+// 23 swift-frontend           0x0000000101664c2c llvm::Expected<swift::ExecuteSILPipelineRequest::OutputType> swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest>(swift::ExecuteSILPipelineRequest const&) + 252
+// 24 swift-frontend           0x0000000101656618 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 68
+// 25 swift-frontend           0x0000000101669014 swift::runSILDiagnosticPasses(swift::SILModule&) + 92
+// 26 swift-frontend           0x0000000100e81634 swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 72
+// 27 swift-frontend           0x0000000100e273cc performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule> >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 676
+// 28 swift-frontend           0x0000000100e26db8 swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 1028
+// 29 swift-frontend           0x0000000100e28870 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 3012
+// 30 swift-frontend           0x0000000100d62830 swift::mainEntry(int, char const**) + 484
+// 31 dyld                     0x00000001179d90f4 start + 520
