Merge pull request #81345 from xedin/rdar-150777469

[CSFix] SE-0470: Warn about missing `@Sendable` for unapplied static …

Author: xedin

lib/Sema/CSFix.cpp

@@ -282,10 +282,30 @@ getConcurrencyFixBehavior(ConstraintSystem &cs, ConstraintKind constraintKind,
   // We can only handle the downgrade for conversions.
   switch (constraintKind) {
   case ConstraintKind::Conversion:
-  case ConstraintKind::ArgumentConversion:
   case ConstraintKind::Subtype:
     break;
 
+  case ConstraintKind::ArgumentConversion: {
+    if (!forSendable)
+      break;
+
+    // Passing a static member reference as an argument needs to be downgraded
+    // to a warning until future major mode to maintain source compatibility for
+    // code with non-Sendable metatypes.
+    if (!cs.getASTContext().LangOpts.isSwiftVersionAtLeast(7)) {
+      auto *argLoc = cs.getConstraintLocator(locator);
+      if (auto *argument = getAsExpr(simplifyLocatorToAnchor(argLoc))) {
+        if (auto overload = cs.findSelectedOverloadFor(
+                argument->getSemanticsProvidingExpr())) {
+          auto *decl = overload->choice.getDecl();
+          if (decl && decl->isStatic())
+            return FixBehavior::DowngradeToWarning;
+        }
+      }
+    }
+    break;
+  }
+
   default:
     if (!cs.shouldAttemptFixes())
       return std::nullopt;

test/Concurrency/sendable_metatype_typecheck.swift

@@ -147,3 +147,31 @@ final class TestStaticMembers<T> {
     let _: @Sendable () -> GenericS<Int> = GenericS.h // Ok
   }
 }
+
+// Downgrade use of static member references on non-Sendable base to a warning until next major mode to maintain source compatibility.
+do {
+  struct S<U> {
+    static func test(_: U, _: U) -> Bool { false }
+  }
+
+  func compute<T>(_: S<T>, _: @escaping @Sendable (T, T) -> Bool) {}
+
+  func test<T: Comparable>(s: S<T>) {
+    compute(s, >) // expected-warning {{converting non-sendable function value to '@Sendable (T, T) -> Bool' may introduce data races}}
+    compute(s, S.test) // expected-warning {{capture of non-sendable type 'T.Type' in an isolated closure}}
+  }
+}
+
+infix operator <=> : ComparisonPrecedence
+
+struct TestUnapplied<U> : Comparable {
+  static func <(_: TestUnapplied<U>, _: TestUnapplied<U>) -> Bool { false }
+}
+
+extension TestUnapplied {
+  static func <=>(_: Self, _: @escaping @Sendable (U, U) -> Bool) {}
+}
+
+func testUnappliedWithOpetator<T: Comparable>(v: TestUnapplied<T>) {
+  v<=>(>) // expected-error {{converting non-sendable function value to '@Sendable (T, T) -> Bool' may introduce data races}}
+}