Skip to content

[Windows] Support skipping update-checkout in utils/build-windows-toolchain.bat #69483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shahmishal opened this issue Oct 28, 2023 · 1 comment
Closed

[Windows] Support skipping update-checkout in utils/build-windows-toolchain.bat #69483

shahmishal opened this issue Oct 28, 2023 · 1 comment
Assignees
@compnerd
Labels
Windows Platform: Windows

Comments

@shahmishal
Copy link
Member

To build the nightly toolchain for Windows, we need to check out specific SHA. However, currently utils/build-windows-toolchain.bat overwrites the checkout from CI. We need a way to disable update-checkout in utils/build-windows-toolchain.bat
@shahmishal shahmishal added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows labels Oct 28, 2023
@shahmishal shahmishal mentioned this issue Oct 28, 2023
Open
@shahmishal shahmishal removed bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Oct 28, 2023
@compnerd
Copy link
Member

compnerd commented Nov 3, 2023

SKIP_UPDATE_CHECKOUT should skip over that step. With build.ps1, we should be able to structure the tools however we need as it focuses only on the build portion and leaves syncing the repositories to the developer.

@compnerd compnerd closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compnerd @shahmishal